From: Thomas Monjalon <thomas@monjalon.net> To: dev@dpdk.org Cc: stable@dpdk.org, David Marchand <david.marchand@redhat.com>, Bruce Richardson <bruce.richardson@intel.com> Subject: [dpdk-dev] [PATCH] eal: fix version macro Date: Wed, 17 Mar 2021 10:31:24 +0100 Message-ID: <20210317093124.965624-1-thomas@monjalon.net> (raw) The macro RTE_VERSION is broken since updated with function calls. It is a build-time version number, and must be built with macros. For a run-time version number, there is the function rte_version(). Fixes: 5b637a848195 ("eal: fix querying DPDK version at runtime") Cc: stable@dpdk.org Reported-by: David Marchand <david.marchand@redhat.com> Signed-off-by: Thomas Monjalon <thomas@monjalon.net> --- lib/librte_eal/include/rte_version.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/include/rte_version.h b/lib/librte_eal/include/rte_version.h index 2f3f727b46..736c5703be 100644 --- a/lib/librte_eal/include/rte_version.h +++ b/lib/librte_eal/include/rte_version.h @@ -28,10 +28,10 @@ extern "C" { * All version numbers in one to compare with RTE_VERSION_NUM() */ #define RTE_VERSION RTE_VERSION_NUM( \ - rte_version_year(), \ - rte_version_month(), \ - rte_version_minor(), \ - rte_version_release()) + RTE_VER_YEAR, \ + RTE_VER_MONTH, \ + RTE_VER_MINOR, \ + RTE_VER_RELEASE) /** * Function to return DPDK version prefix string -- 2.30.1
next reply other threads:[~2021-03-17 9:31 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-17 9:31 Thomas Monjalon [this message] 2021-03-17 9:48 ` David Marchand 2021-03-17 10:01 ` Thomas Monjalon 2021-03-18 12:28 ` Bruce Richardson 2021-03-18 14:41 ` Thomas Monjalon 2021-03-18 15:45 ` Bruce Richardson 2021-03-17 15:36 ` David Marchand 2021-03-17 15:39 ` Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210317093124.965624-1-thomas@monjalon.net \ --to=thomas@monjalon.net \ --cc=bruce.richardson@intel.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git