From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id F301BA0561;
	Thu, 18 Mar 2021 20:40:29 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6BDFE140ECE;
	Thu, 18 Mar 2021 20:40:29 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id DF19240698
 for <dev@dpdk.org>; Thu, 18 Mar 2021 20:40:27 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1059)
 id 200EC209C383; Thu, 18 Mar 2021 12:40:27 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 200EC209C383
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1616096427;
 bh=hVTl09EmCts+4F30mwCsByDfSExxLORinEm2Hxkyiwo=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=H8uMdHLn7HrovriHBGWQQGDP5LovCd9tv8xVFjQmVYdu/H67S5pawy5jE0DayJhrT
 OubB/8XozPNtGeAR8fKNSl7vkGuGjLYqnvvU16X5vaPNIGHwvaRYUJcP5JkaaDFkG0
 ouT0mXJpau6vS+pyfMxpGwBNmki2tZaP2RTnYt+o=
Date: Thu, 18 Mar 2021 12:40:27 -0700
From: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
 Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
 Khoa To <khot@microsoft.com>, navasile@microsoft.com,
 "Dmitry Malloy (MESHCHANINOV)" <dmitrym@microsoft.com>,
 roretzla@microsoft.com, Omar Cardona <ocardona@microsoft.com>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Pallavi Kadam <pallavi.kadam@intel.com>
Message-ID: <20210318194027.GA8824@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1616029240-26588-1-git-send-email-navasile@linux.microsoft.com>
 <1616029240-26588-2-git-send-email-navasile@linux.microsoft.com>
 <CAJFAV8wHu8cc0iNpC_HMpVbsMFJtUK_jUo6MuSH5SZ=ppf8=kQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJFAV8wHu8cc0iNpC_HMpVbsMFJtUK_jUo6MuSH5SZ=ppf8=kQ@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH 1/3] Add EAL threads API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Mar 18, 2021 at 04:48:49PM +0100, David Marchand wrote:
> On Thu, Mar 18, 2021 at 2:01 AM Narcisa Ana Maria Vasile
> <navasile@linux.microsoft.com> wrote:
> > diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c
> > index 73a055902..5219e783e 100644
> > --- a/lib/librte_eal/common/eal_common_thread.c
> 
> rte_thread_*et_affinity() are stable.
> This breaks the ABI (which is bad) and this API change was not
> announced previously.
> 
  Thank you David, I will revert the renaming of the stable
  functions to fix the ABI break.

  Given that the original functions only operate on the current thread
  (using the _thread_self()), changing their names to 
  rte_thread_self_*et_affinity() brings more clarity to the purpose of
  the functions. We will propose an ABI change to rename
  them in the next release (following the proper ABI changes procedures).

> -- 
> David Marchand