From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B4F3A0562; Fri, 19 Mar 2021 05:08:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0916D4067C; Fri, 19 Mar 2021 05:08:30 +0100 (CET) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by mails.dpdk.org (Postfix) with ESMTP id 6BBA540143; Fri, 19 Mar 2021 05:08:28 +0100 (CET) Received: by mail-pf1-f172.google.com with SMTP id x184so4960393pfd.6; Thu, 18 Mar 2021 21:08:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aEQ18sCC5TFAdvCb9ZMBbnG+tvJiRO8FB3Sfc8dTqUU=; b=OOXA2mC8tX0pVeC9DZygT9vo18J+LxksY7BKqXKrp93qTkynMYX3l+ZuUjURbhkz8e J2lLuxGaMwe5Oo0o7d/81SidK0v7gsYpVehvREzwRhN55f+HIHo76yvwnnR9Jyienfns btCJm0wFftVzp8ILBWsJpmhg3BJc9N0avoDLn+m6H5d3mksf5Jup2ADLa61v3zTWbGcn QFlLqr+u20BCVrjJ1eAsmulZBwwpB4UeGm8/1gJDX8KxKp8vmJqFyzlp+XxG8tt5JF/T RbCrvfLPw7r3h+eOPkDTnnOgnObMVKyEedr5oYLpcA9SB8frJdX4muOKFQb437tv4xKZ CNeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aEQ18sCC5TFAdvCb9ZMBbnG+tvJiRO8FB3Sfc8dTqUU=; b=jEJGZaMGoWqlGrCml1ONHPE6i4dKIaA1AlEcLsrliCdN7kP5oBH7LJSvV/rT32D+pn 0wIIwdXkfGxnXsVcPdy31Y35UhZU4fY+Bo4qE1YPc4EiTLs9W72ttJwwTJGnxxBJFmqJ 5IH9M19OBu2YfH3Zkl/jeYmB0iINiLuWoZeZixu0hqaQfqPKmwm87bFhJIuPC3ofCYvi 3jUmohXwx8Of8LDh/LhedU2c94UYxLi5fe9QVFaBD3dGmuvfrMONc7BdHH/NVjc77IjF XEBJG8IAS8Cni6aq9c6CAwNFawoTtiUrN4FUtuXYqwY+W6UOMUyOqV74FdCUOrrDv4jR FsUw== X-Gm-Message-State: AOAM5322NTpkIlgeCOJVtS3Q/Oi+BNEZdrEgIg9r7SkVcwwwyFb1JZK3 JSULhqz/FDlW+nM2hC/AnFk= X-Google-Smtp-Source: ABdhPJxoUQ26BGfoanmhMOUxAV5mWr9ZLZ/6g2jqgffm/g+S/Ovy10vHq+QBoSeCkhD8IMD7dte9pA== X-Received: by 2002:a65:4785:: with SMTP id e5mr10111513pgs.0.1616126906964; Thu, 18 Mar 2021 21:08:26 -0700 (PDT) Received: from localhost.localdomain ([104.192.108.10]) by smtp.gmail.com with ESMTPSA id g21sm3432487pjl.28.2021.03.18.21.08.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 21:08:26 -0700 (PDT) From: Xiaozhen Ban <benhaz1024@gmail.com> To: jia.guo@intel.com, haiyue.wang@intel.com Cc: dev@dpdk.org, stable@dpdk.org Date: Fri, 19 Mar 2021 12:08:17 +0800 Message-Id: <20210319040817.64143-1-benhaz1024@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <BN8PR11MB3795C33F2D84F652837ACE2DF7699@BN8PR11MB3795.namprd11.prod.outlook.com> References: <BN8PR11MB3795C33F2D84F652837ACE2DF7699@BN8PR11MB3795.namprd11.prod.outlook.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix filter control return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > > -----Original Message----- > > From: Xiaozhen Ban <benhaz1024 at gmail.com> > > Sent: Thursday, March 18, 2021 19:44 > > To: Guo, Jia <jia.guo at intel.com>; Wang, Haiyue <haiyue.wang at intel.com> > > Cc: dev at dpdk.org; stable at dpdk.org > > Subject: RE: RE: [PATCH] net/e1000: fix filter control return value > > > > OK, but I think this bug affects all stable release about 6 years before today. > I don't think so, since it is PMD internal ops, the real API 'rte_flow_ops_get' > always use RTE_ETH_FILTER_GENERIC. ;-) eth_igb_filter_ctrl() called by rte_eth_dev_filter_ctrl(), if application developer know how to use the parameter filter_type correctly, it's OK. otherwise he will get rte_eth_dev_filter_ctrl() return value is success but actually is failed.