From: dapengx.yu@intel.com
To: reshma.pattan@intel.com
Cc: dev@dpdk.org, Dapeng Yu <dapengx.yu@intel.com>,
shahafs@mellanox.com, stable@dpdk.org
Subject: [dpdk-dev] [PATCH v2] examples/packet_ordering: use local port config
Date: Fri, 19 Mar 2021 15:11:18 +0800 [thread overview]
Message-ID: <20210319071118.945615-1-dapengx.yu@intel.com> (raw)
In-Reply-To: <20210311063654.233157-1-dapengx.yu@intel.com>
From: Dapeng Yu <dapengx.yu@intel.com>
A global ethernet port configuration is assigned to local variable
because in this way the local variable may be updated as required. But
this local variable is not used as input of rte_eth_dev_configure() in
original implementation, and cause that fast mbuf free feature cannot
be enabled on port.
This patch use this local variable as input of rte_eth_dev_configure().
Fixes: 6833f919f56b ("examples/packet_ordering: convert to new ethdev offloads API")
Cc: shahafs@mellanox.com
Cc: stable@dpdk.org
Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
Acked-by: Reshma Pattan <reshma.pattan@intel.com>
---
v2:
* Add Cc:<original author> and Acked-by:<maintainer>
examples/packet_ordering/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/packet_ordering/main.c b/examples/packet_ordering/main.c
index 4bea1982d..963b11d6d 100644
--- a/examples/packet_ordering/main.c
+++ b/examples/packet_ordering/main.c
@@ -290,7 +290,7 @@ configure_eth_port(uint16_t port_id)
if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)
port_conf.txmode.offloads |=
DEV_TX_OFFLOAD_MBUF_FAST_FREE;
- ret = rte_eth_dev_configure(port_id, rxRings, txRings, &port_conf_default);
+ ret = rte_eth_dev_configure(port_id, rxRings, txRings, &port_conf);
if (ret != 0)
return ret;
--
2.27.0
next prev parent reply other threads:[~2021-03-19 7:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 6:36 [dpdk-dev] [PATCH] " dapengx.yu
2021-03-18 10:18 ` Pattan, Reshma
2021-03-19 7:11 ` dapengx.yu [this message]
2021-03-24 10:17 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319071118.945615-1-dapengx.yu@intel.com \
--to=dapengx.yu@intel.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).