From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0D04A0524; Sat, 20 Mar 2021 14:05:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E11F141086; Sat, 20 Mar 2021 14:05:51 +0100 (CET) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by mails.dpdk.org (Postfix) with ESMTP id 836634067A for ; Sat, 20 Mar 2021 14:05:49 +0100 (CET) Received: by mail-lf1-f53.google.com with SMTP id 75so14239712lfa.2 for ; Sat, 20 Mar 2021 06:05:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Dvnd84bn2ihQoOHeOiX4gDkXHreas2cjUEHbdqInvWo=; b=ZvK3IBpFpewsKw2e1KbcjklXKleZ4bPLJvsXrguY6tQDdV1nqp6o5wB8qirr+17+oM 8VaWIRCroLjMxW6vIH1UlzBFjaiJtTIP+3zqkNEX9Fvqa8SNbWm0t79zJ9k0ZlJIwmck 6GEFSmtEQ84CXOSb4K5FwqvVxWuUq4fUZNJpBv+JuzDmCFsA+86XZr77GPV66PJ39w1q RFJXcnlCIzWKoAUL1uDI4G8ie3V9pTSGnxUgXpU7NCMOiTl1oTUJ1ttfSZI9XUAiZvmb jh8XjwhXpB5q1Hy1Neu1XD5bAp0wGLf3tlfmVQYXRCdopArTaOxIjkHmHvWhsDomxvP1 OwdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Dvnd84bn2ihQoOHeOiX4gDkXHreas2cjUEHbdqInvWo=; b=NZTPQZ1uSRXAmW1UmXDe6GX8EabXJOt5NwdYCErBuyyYz5Ptb2esyegOj8wsj3BQlW WZtt6EPQeBd0cCZ0zU/6gzl8Pd6bF58yIwPFqdNt8JCOYjx65mMdu84+Pg3U7QyrLiEh v3+MBQBaWCLWgakT9P5p8xpBQShwFGZoInADmuIliW1RBcIyDSmh5kM410Via4hbwzTP zXp/SDHh5SWdWjASOEt588cWWnf4jxxDeHeqo0ykKkr2WLOLPJQVMThvFIPfxuZBxUws eDcWUxsi5dSTP9ZqccYW+IIqEVhtZbyDUPlkap/Mkh1iZi0Y79gVg6QKSgWnmjCeVfKH UnYw== X-Gm-Message-State: AOAM5302PExGW/6HlHkIcH0gj+Y7IJW/jynAA+YhPIp6TvyXeComb0Xm 32XpydOmh/q24MWwUE3CaHpEDKhQMUUUPYsu X-Google-Smtp-Source: ABdhPJyTefhdXAIs3pVGWL+o/4u3BQqTn+MPFzNYqkV0rY95q2mcjri8UiUwcuz8Yn7yNIHpQcvWIg== X-Received: by 2002:a19:604c:: with SMTP id p12mr3758047lfk.30.1616245547342; Sat, 20 Mar 2021 06:05:47 -0700 (PDT) Received: from localhost.localdomain (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id r66sm929610lff.93.2021.03.20.06.05.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Mar 2021 06:05:46 -0700 (PDT) From: Dmitry Kozlyuk To: dev@dpdk.org Cc: Tyler Retzlaff , Jie Zhou , Dmitry Kozlyuk Date: Sat, 20 Mar 2021 16:05:20 +0300 Message-Id: <20210320130525.16452-1-dmitry.kozliuk@gmail.com> X-Mailer: git-send-email 2.29.3 In-Reply-To: <20210320112733.13160-1-dmitry.kozliuk@gmail.com> References: <20210320112733.13160-1-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v6 0/5] eal/windows: do not expose POSIX symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Windows, EAL contains two sets of functions and macros for POSIX compatibility: and a networking shim (socket headers). The latter conflicts with system headers and should not exist. Exposing the former from EAL can break consumer own POSIX compatibility layer and is against standards in general. Hide these symbols from external consumers, while keeping them available for DPDK code. v6: * Rebase on ToT to resolve conflicts. v5: * Unify series with removing Windows networking shim to eliminate dependency between series and CI failures. * RTE_BUILD_INTERNAL -> rte_os_internal.h (Thomas Monjalon). * Remove release notes: hidden symbols were never part of API. Dmitry Kozlyuk (5): eal: add sleep API eal/windows: hide asprintf() shim eal: make OS shims internal net: provide IP-related API on any OS net: replace Windows networking shim drivers/bus/pci/private.h | 4 +- drivers/bus/vdev/vdev_private.h | 2 + drivers/common/mlx5/mlx5_common.h | 1 + drivers/net/i40e/i40e_ethdev.c | 1 + drivers/net/i40e/i40e_fdir.c | 1 + drivers/net/mlx5/mlx5.h | 2 +- drivers/net/mlx5/mlx5_flow.c | 4 +- drivers/net/mlx5/mlx5_flow.h | 4 +- drivers/net/mlx5/mlx5_mac.c | 1 - examples/cmdline/commands.c | 5 - examples/cmdline/parse_obj_list.c | 2 - lib/librte_cmdline/cmdline.c | 5 - lib/librte_cmdline/cmdline_os_windows.c | 2 - lib/librte_cmdline/cmdline_parse.c | 2 - lib/librte_cmdline/cmdline_parse_etheraddr.c | 6 -- lib/librte_cmdline/cmdline_parse_ipaddr.c | 6 -- lib/librte_cmdline/cmdline_parse_ipaddr.h | 2 +- lib/librte_cmdline/cmdline_private.h | 1 + lib/librte_cmdline/cmdline_socket.c | 4 - lib/librte_eal/common/eal_common_config.c | 1 - lib/librte_eal/common/eal_common_errno.c | 4 + lib/librte_eal/common/eal_common_options.c | 2 +- lib/librte_eal/common/eal_common_timer.c | 5 +- lib/librte_eal/common/eal_internal_cfg.h | 1 + lib/librte_eal/common/eal_private.h | 11 +++ .../freebsd/include/rte_os_internal.h | 14 +++ lib/librte_eal/include/rte_thread.h | 11 +++ .../linux/include/rte_os_internal.h | 14 +++ lib/librte_eal/rte_eal_exports.def | 2 + lib/librte_eal/unix/rte_thread.c | 10 +- lib/librte_eal/version.map | 1 + lib/librte_eal/windows/eal.c | 30 ++++++ lib/librte_eal/windows/eal_hugepages.c | 1 - lib/librte_eal/windows/eal_lcore.c | 1 - lib/librte_eal/windows/eal_memalloc.c | 1 - lib/librte_eal/windows/eal_thread.c | 9 +- lib/librte_eal/windows/include/arpa/inet.h | 30 ------ lib/librte_eal/windows/include/netinet/in.h | 38 -------- lib/librte_eal/windows/include/netinet/ip.h | 10 -- lib/librte_eal/windows/include/rte_os.h | 92 +------------------ .../windows/include/rte_os_internal.h | 36 ++++++++ lib/librte_eal/windows/include/sys/socket.h | 24 ----- lib/librte_ethdev/ethdev_private.h | 2 + lib/librte_ethdev/rte_ethdev.c | 13 +-- lib/librte_ethdev/rte_ethdev_core.h | 1 - lib/librte_kvargs/rte_kvargs.c | 1 + lib/librte_net/rte_ether.h | 26 ++++-- lib/librte_net/rte_ip.h | 7 ++ lib/librte_net/rte_net.c | 1 + 49 files changed, 200 insertions(+), 254 deletions(-) create mode 100644 lib/librte_eal/freebsd/include/rte_os_internal.h create mode 100644 lib/librte_eal/linux/include/rte_os_internal.h delete mode 100644 lib/librte_eal/windows/include/arpa/inet.h delete mode 100644 lib/librte_eal/windows/include/netinet/in.h delete mode 100644 lib/librte_eal/windows/include/netinet/ip.h create mode 100644 lib/librte_eal/windows/include/rte_os_internal.h delete mode 100644 lib/librte_eal/windows/include/sys/socket.h -- 2.29.3