From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 7CE6DA034F;
Mon, 22 Mar 2021 09:39:26 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 91EFC140DCA;
Mon, 22 Mar 2021 09:39:22 +0100 (CET)
Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com
[62.23.145.76]) by mails.dpdk.org (Postfix) with ESMTP id 76BCC140DBA
for <dev@dpdk.org>; Mon, 22 Mar 2021 09:39:20 +0100 (CET)
Received: from localhost (unknown [10.16.0.62])
by proxy.6wind.com (Postfix) with ESMTP id 71C5B914423;
Mon, 22 Mar 2021 09:39:20 +0100 (CET)
From: Gabriel Ganne <gabriel.ganne@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, olivier.matz@6wind.com, thierry.herbelot@6wind.com,
Gabriel Ganne <gabriel.ganne@6wind.com>
Date: Mon, 22 Mar 2021 09:39:01 +0100
Message-Id: <20210322083901.22493-3-gabriel.ganne@6wind.com>
X-Mailer: git-send-email 2.29.2
In-Reply-To: <20210322083901.22493-1-gabriel.ganne@6wind.com>
References: <20210322083901.22493-1-gabriel.ganne@6wind.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH 3/3] meson: remove unnecessary explicit link to
libpcap
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
libpcap is already found and registered as a dependency by meson, and
the dependency is already correctly used in librte_port. This line is
just unnecessary.
It also has the side effect of messing with the meson link line: dpdk
link will be declared twice: manually and then through pkg-config. If
you configure meson to prefer static linking over dynamic, this will
cause the build to fail on librte_port, since the pcap deps are not yet
seen by the linker.
Signed-off-by: Gabriel Ganne <gabriel.ganne@6wind.com>
---
config/meson.build | 1 -
1 file changed, 1 deletion(-)
diff --git a/config/meson.build b/config/meson.build
index 0fb7e1b27a0f..3eb90327dfcc 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -177,7 +177,6 @@ if not pcap_dep.found()
endif
if pcap_dep.found() and cc.has_header('pcap.h', dependencies: pcap_dep)
dpdk_conf.set('RTE_PORT_PCAP', 1)
- dpdk_extra_ldflags += '-lpcap'
endif
# for clang 32-bit compiles we need libatomic for 64-bit atomic ops
--
2.29.2