From: Bruce Richardson <bruce.richardson@intel.com>
To: Gabriel Ganne <gabriel.ganne@6wind.com>
Cc: dev@dpdk.org, olivier.matz@6wind.com, thierry.herbelot@6wind.com
Subject: Re: [dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version
Date: Mon, 22 Mar 2021 09:34:21 +0000 [thread overview]
Message-ID: <20210322093421.GA1440@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20210322083901.22493-1-gabriel.ganne@6wind.com>
On Mon, Mar 22, 2021 at 09:38:59AM +0100, Gabriel Ganne wrote:
> WARNING: Project targetting '>= 0.47.1' but tried to use feature introduced
> in '0.48.0': console arg in custom_target
>
> console argument is used within kernel/linux/kni/meson.build
>
> Signed-off-by: Gabriel Ganne <gabriel.ganne@6wind.com>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 7778e18200a9..65c46f051365 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -8,7 +8,7 @@ project('DPDK', 'C',
> files('VERSION')).stdout().strip(),
> license: 'BSD',
> default_options: ['buildtype=release', 'default_library=static'],
> - meson_version: '>= 0.47.1'
> + meson_version: '>= 0.48.0'
> )
>
No objection to this on my part. Rather than bumping to just 0.48, I think
we might as well jump a couple of versions. For example, 0.49 adds support
for "break" and "continue" keywords which could allow loop simplification.
Beyond that, it's a matter of how up-to-date we want to be...
next prev parent reply other threads:[~2021-03-22 9:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 8:38 Gabriel Ganne
2021-03-22 8:39 ` [dpdk-dev] [PATCH 2/3] meson: use threads dependency as provided by meson Gabriel Ganne
2021-03-22 8:39 ` [dpdk-dev] [PATCH 3/3] meson: remove unnecessary explicit link to libpcap Gabriel Ganne
2021-03-22 9:34 ` Bruce Richardson [this message]
2021-03-22 15:25 ` [dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version Dmitry Kozlyuk
2021-03-23 6:22 ` Gabriel Ganne
2021-03-23 7:16 ` Andrew Rybchenko
2021-03-23 7:42 ` Dmitry Kozlyuk
2021-03-23 9:38 ` Bruce Richardson
2021-04-01 11:09 ` Bruce Richardson
2021-03-22 13:57 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210322093421.GA1440@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gabriel.ganne@6wind.com \
--cc=olivier.matz@6wind.com \
--cc=thierry.herbelot@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).