From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D2FFA034F; Mon, 22 Mar 2021 10:34:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2483D40040; Mon, 22 Mar 2021 10:34:32 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 43ED54003D for ; Mon, 22 Mar 2021 10:34:29 +0100 (CET) IronPort-SDR: pKq8sTB8lLTyLbCjm4VDS0CaoK/3rNgMjP2LiVVDJZCX3/J07t1KB3+vDb6mSoVO7Qn/3lztK0 pug48aX3d0uQ== X-IronPort-AV: E=McAfee;i="6000,8403,9930"; a="189636594" X-IronPort-AV: E=Sophos;i="5.81,268,1610438400"; d="scan'208";a="189636594" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2021 02:34:28 -0700 IronPort-SDR: MFpHYyQMEFuu6DXE7POR8WRPALHOw34T/2wrKLfAOEOfhy0cysp8o7H82j6XTIr6QRHVBNoXwg Fi1Up3zNABfg== X-IronPort-AV: E=Sophos;i="5.81,268,1610438400"; d="scan'208";a="390421813" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.12.114]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 22 Mar 2021 02:34:26 -0700 Date: Mon, 22 Mar 2021 09:34:21 +0000 From: Bruce Richardson To: Gabriel Ganne Cc: dev@dpdk.org, olivier.matz@6wind.com, thierry.herbelot@6wind.com Message-ID: <20210322093421.GA1440@bricha3-MOBL.ger.corp.intel.com> References: <20210322083901.22493-1-gabriel.ganne@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210322083901.22493-1-gabriel.ganne@6wind.com> Subject: Re: [dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Mar 22, 2021 at 09:38:59AM +0100, Gabriel Ganne wrote: > WARNING: Project targetting '>= 0.47.1' but tried to use feature introduced > in '0.48.0': console arg in custom_target > > console argument is used within kernel/linux/kni/meson.build > > Signed-off-by: Gabriel Ganne > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index 7778e18200a9..65c46f051365 100644 > --- a/meson.build > +++ b/meson.build > @@ -8,7 +8,7 @@ project('DPDK', 'C', > files('VERSION')).stdout().strip(), > license: 'BSD', > default_options: ['buildtype=release', 'default_library=static'], > - meson_version: '>= 0.47.1' > + meson_version: '>= 0.48.0' > ) > No objection to this on my part. Rather than bumping to just 0.48, I think we might as well jump a couple of versions. For example, 0.49 adds support for "break" and "continue" keywords which could allow loop simplification. Beyond that, it's a matter of how up-to-date we want to be...