From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D92B5A034F; Mon, 22 Mar 2021 15:08:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3544C406A3; Mon, 22 Mar 2021 15:08:02 +0100 (CET) Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by mails.dpdk.org (Postfix) with ESMTP id 8CD0A4003D for ; Mon, 22 Mar 2021 15:07:59 +0100 (CET) Received: from localhost (unknown [10.16.0.62]) by proxy.6wind.com (Postfix) with ESMTP id 80398914820; Mon, 22 Mar 2021 15:07:59 +0100 (CET) From: Gabriel Ganne To: Bruce Richardson Cc: dev@dpdk.org, olivier.matz@6wind.com, thierry.herbelot@6wind.com, Gabriel Ganne Date: Mon, 22 Mar 2021 15:07:57 +0100 Message-Id: <20210322140757.7888-2-gabriel.ganne@6wind.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210322140757.7888-1-gabriel.ganne@6wind.com> References: <20210322140757.7888-1-gabriel.ganne@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 3/3] meson: remove unnecessary explicit link to libpcap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" libpcap is already found and registered as a dependency by meson, and the dependency is already correctly used in librte_port. This line is just unnecessary. It also has the side effect of messing with the meson link line: dpdk link will be declared twice: manually and then through pkg-config. If you configure meson to prefer static linking over dynamic, this will cause the build to fail on librte_port, since the pcap deps are not yet seen by the linker. Signed-off-by: Gabriel Ganne --- config/meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/config/meson.build b/config/meson.build index 0fb7e1b27a0f..3eb90327dfcc 100644 --- a/config/meson.build +++ b/config/meson.build @@ -177,7 +177,6 @@ if not pcap_dep.found() endif if pcap_dep.found() and cc.has_header('pcap.h', dependencies: pcap_dep) dpdk_conf.set('RTE_PORT_PCAP', 1) - dpdk_extra_ldflags += '-lpcap' endif # for clang 32-bit compiles we need libatomic for 64-bit atomic ops -- 2.29.2