From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 479C2A034F; Mon, 22 Mar 2021 16:26:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA8A040040; Mon, 22 Mar 2021 16:26:00 +0100 (CET) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by mails.dpdk.org (Postfix) with ESMTP id BB2C74003D for ; Mon, 22 Mar 2021 16:25:59 +0100 (CET) Received: by mail-lj1-f169.google.com with SMTP id f16so21617105ljm.1 for ; Mon, 22 Mar 2021 08:25:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=q5iL9bomi10RqcGVSL6GWV6F8jF85kpvNbgVxQzVLes=; b=icyqVgdHFik2irLW2Fe7F3f3uFC7/olUyI52QVZjl+m7AHslz2bld1e9xF45Y39FXT LHluovW9nAx4ezosrHVjeHuygif6GSL5NuXjelvQj4GkxWYAa66Xq1gauE+dDgrKxo9u 8b0QeP9A5IuQSFm6fCKkWg5JYt9tkH0wAitOZFgGI63bTRZLO7XP2iNcHL4STUf7AEZd hraq+cO2ZSbQJ7fQlzd+XeIPD3vM1T1uJjNHadb8ofGlEp0HCSDTCbacXI3MDjZfDto6 7DicIErTsFsmFnJMFTerXj/mHmOx0nRqo2a8KamhdL3royJqmlPTGHf8lO3GP/d1KhMF qgUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=q5iL9bomi10RqcGVSL6GWV6F8jF85kpvNbgVxQzVLes=; b=EI2cHcbLldsyaF4CSDfS71T9X2gDqknQPxI9gD2A96xNO72/y1HtNXLoZsPmul5RDx Y9e9weXsxQNg5Wiok2M8dYd68LATqtJJ5lVUdVV1LMFJlY19dN3zmcyuxksrxznitdXO PgtT2SwIVbOG4OAW6fvid7UcCXzcNkpgP0ZsenfmKghMjPh7JoHKsaTLCeJcHGb3ygTR BDTmrOmDmhkWBww2u5GoyYHz6Bb+oBi0iz1asNqgelNwgLNKBbT/VDu6RwgopkbHuj1/ DQxIwE6gAoboUSqxAxHT8dt0xxHLh49s3k4S4R5r7VhcBCKGZKmoCFWPhMDO2XBhSicY TgqQ== X-Gm-Message-State: AOAM531Hr8ry9Y9WfvZfvTZ8SiepqciMKzMCJXQwScDlkh4+HLehg23L s3H/sIZag4jVmOZYwzg18o4= X-Google-Smtp-Source: ABdhPJxj4EFT5MzQWcT7jRR/p3dvrIXbmTD6gxvXc1YxTO2Tte7S+gjZ4fCSpd2VG0tXbEzPhYSalQ== X-Received: by 2002:a2e:87ca:: with SMTP id v10mr113081ljj.96.1616426759255; Mon, 22 Mar 2021 08:25:59 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id h4sm1981111lji.84.2021.03.22.08.25.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 08:25:58 -0700 (PDT) Date: Mon, 22 Mar 2021 18:25:57 +0300 From: Dmitry Kozlyuk To: Bruce Richardson Cc: Gabriel Ganne , dev@dpdk.org, olivier.matz@6wind.com, thierry.herbelot@6wind.com Message-ID: <20210322182557.4dd1261b@sovereign> In-Reply-To: <20210322093421.GA1440@bricha3-MOBL.ger.corp.intel.com> References: <20210322083901.22493-1-gabriel.ganne@6wind.com> <20210322093421.GA1440@bricha3-MOBL.ger.corp.intel.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-03-22 09:34 (UTC+0000), Bruce Richardson: > On Mon, Mar 22, 2021 at 09:38:59AM +0100, Gabriel Ganne wrote: > > WARNING: Project targetting '>=3D 0.47.1' but tried to use feature intr= oduced > > in '0.48.0': console arg in custom_target > >=20 > > console argument is used within kernel/linux/kni/meson.build > >=20 > > Signed-off-by: Gabriel Ganne > > --- > > meson.build | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/meson.build b/meson.build > > index 7778e18200a9..65c46f051365 100644 > > --- a/meson.build > > +++ b/meson.build > > @@ -8,7 +8,7 @@ project('DPDK', 'C', > > files('VERSION')).stdout().strip(), > > license: 'BSD', > > default_options: ['buildtype=3Drelease', 'default_library=3Dstatic'], > > - meson_version: '>=3D 0.47.1' > > + meson_version: '>=3D 0.48.0' > > ) > > =20 >=20 > No objection to this on my part. Rather than bumping to just 0.48, I think > we might as well jump a couple of versions. For example, 0.49 adds support > for "break" and "continue" keywords which could allow loop simplification. > Beyond that, it's a matter of how up-to-date we want to be... FYI, recalling some TODOs and which versions would allow to resolve them. =46rom https://mails.dpdk.org/archives/dev/2021-January/196000.html: A script to extract object files from library is still required. Meson has extract_all_objects(), but they can't be passed as inputs to custom_target() until 0.52.0 (commit f431cff809). buildtools/meson.build: # TODO: starting from Meson 0.51.0 use # python3 =3D import('python').find_installation('python', # modules : python3_required_modules) config/meson.build: # TODO: use cc.get_linker_id() with Meson >=3D 0.54 is_ms_linker =3D is_windows and (cc.get_id() =3D=3D 'clang')