From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18680A034F; Mon, 22 Mar 2021 23:18:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 79D7C40040; Mon, 22 Mar 2021 23:18:04 +0100 (CET) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by mails.dpdk.org (Postfix) with ESMTP id 5CD8F4003D for <dev@dpdk.org>; Mon, 22 Mar 2021 23:18:03 +0100 (CET) Received: by mail-lj1-f169.google.com with SMTP id f16so23111891ljm.1 for <dev@dpdk.org>; Mon, 22 Mar 2021 15:18:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bWJ8YWMd6ZyOjjHxijbUWL7rEKSPg68NIZV2vkySa48=; b=JChk8nrspVurPpyko5pSvGrZ3ComzcOrQ5BTJI85gyRD/P++Gs9F36/6kBbcaZiVZG uDc1N57L870Ik3HgyYT5UXT5u0UUAwSr5K1gVBgw0Qw7s0z4HT2a9HLaA/SYmLaOW6bA 6t3fsxto+2vjVdvAiLVNhhQx8CgAX2gbfK4c6tNASC/gyA/Mp+lLCUNc9ssJAl5D6Dp+ 69Qx+l6mtsE5AEhoFc8G6XSUy/kxAAr8N3Rx5ko55/6T/UyBGQRtdrhcxUt7alU/kta5 2dloEZwAhNH0M3pBwFfZI24J31eSh6yV0J2mCUb7JH3HzPVZjJQgaIUEy3/ww4ekcKzr JAIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bWJ8YWMd6ZyOjjHxijbUWL7rEKSPg68NIZV2vkySa48=; b=UB3wXupHmI+O+3MxKa/B0p3uQZtxg3uIsqpKL7GDiu0pOGI2XhA+FzvyNIiTim+sZL A6DOIQu6p0YXP+ZvGJRPb3ZhXzWzWVI4mxLw2wDXAu6wnYNMmlbrv3iC+6Z4LjIDNhCY gv/VU5ghfz942JyvLowsGo6G2NeXsDRl9TgH9qICZLIOZ2nhknvkuYs5LN3X4+b/ORt2 /I4uMU4Zo6Y/SZF8zV6BYZ0pSgxtBHlfv7/oCmWKKjS7T+bRSUvap1sVHH4VL2p6MdAC WIVA1KrhGIXx+sTqXVdtEX+sqflDSbPtb4LJvxM6/2QVxvmdmbouc5horRa/SeR9B7lg wn5A== X-Gm-Message-State: AOAM532z0n+vT7FR/EYqoGVB4HklW4391N2/xlUMomz2AITjXETZm4Mt 0R85XeunGatves/5zikLTL4= X-Google-Smtp-Source: ABdhPJzGMqzy24NeSYeVg9EJd1OxwJLtiZRpmfG3GUEL1jKfGUa3uRappJFA/VffVFIkJR7lB4893w== X-Received: by 2002:a05:651c:545:: with SMTP id q5mr1031620ljp.14.1616451482825; Mon, 22 Mar 2021 15:18:02 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id n11sm2080893ljg.7.2021.03.22.15.18.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 15:18:02 -0700 (PDT) Date: Tue, 23 Mar 2021 01:18:00 +0300 From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> To: Nick Connolly <nick.connolly@mayadata.io> Cc: Gabriel Ganne <gabriel.ganne@6wind.com>, Bruce Richardson <bruce.richardson@intel.com>, Kevin Laatz <kevin.laatz@intel.com>, dev@dpdk.org, olivier.matz@6wind.com, thierry.herbelot@6wind.com, "Dmitry Malloy (MESHCHANINOV)" <dmitrym@microsoft.com>, tal Shnaiderman <talshn@nvidia.com>, "Menon, Ranjit" <ranjit.menon@intel.com>, Thomas Monjalon <thomas@monjalon.net>, Tyler Retzlaff <roretzla@microsoft.com> Message-ID: <20210323011800.2a50fde8@sovereign> In-Reply-To: <ef970bc2-ff13-8d78-d564-eaefc24117c7@mayadata.io> References: <20210322140757.7888-1-gabriel.ganne@6wind.com> <ef970bc2-ff13-8d78-d564-eaefc24117c7@mayadata.io> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 2/3] meson: use threads dependency as provided by meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 2021-03-22 16:04 (UTC+0000), Nick Connolly: > > meson guarantees this is portable, so this also allows us to remove a > > is_windows switch. > Hi Gabriel, > > On Windows, there are at least three different compilation options: > > * MinGW-w64 with posix threads > * MinGW-w64 with win32 threads (different download) > * Clang without threads support > > The Windows EAL library doesn't use a threads package and instead uses > it's own wrappers around the native Windows system calls. Given that, I > believe the existing behaviour of not specifying the pthreads package > for a Windows build is correct and shouldn't be changed. Hi Nick, Threads is a dummy dependency for Clang. For MinGW without pthread it still adds -pthread switch (and it comes to libdpdk.pc), but executable doesn't require pthread library to run. I can imagine DPDK built by MinGW without pthread be linked via pkg-config to an app built by MinGW with pthread, then -pthread switch will be added from libdpdk.pc. Do you think it's an issue?