From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 570E6A09E4; Tue, 23 Mar 2021 10:38:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 141814014D; Tue, 23 Mar 2021 10:38:33 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 3A2AE40143 for <dev@dpdk.org>; Tue, 23 Mar 2021 10:38:31 +0100 (CET) IronPort-SDR: naOuFgDyJS3ISSQcafaQZ66Q8/+5HDoWAJDycEvRSD0r/IBB+DIriRF12JmDkpwvFQimlEuOBp R5KH1gi2upgg== X-IronPort-AV: E=McAfee;i="6000,8403,9931"; a="254439630" X-IronPort-AV: E=Sophos;i="5.81,271,1610438400"; d="scan'208";a="254439630" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2021 02:38:30 -0700 IronPort-SDR: 8zoEhwHKha09+X3Yt2+kx20zquFi5fwDhduYKoIdk9Y2cAV6v+KVDmZZ5MjsluHnAhOiszn/Go YSLknE2VhQMw== X-IronPort-AV: E=Sophos;i="5.81,271,1610438400"; d="scan'208";a="408239144" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.26.170]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 23 Mar 2021 02:38:28 -0700 Date: Tue, 23 Mar 2021 09:38:25 +0000 From: Bruce Richardson <bruce.richardson@intel.com> To: Gabriel Ganne <gabriel.ganne@6wind.com> Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, dev@dpdk.org, Olivier Matz <olivier.matz@6wind.com>, Thierry Herbelot <thierry.herbelot@6wind.com> Message-ID: <20210323093825.GA1158@bricha3-MOBL.ger.corp.intel.com> References: <20210322083901.22493-1-gabriel.ganne@6wind.com> <20210322093421.GA1440@bricha3-MOBL.ger.corp.intel.com> <20210322182557.4dd1261b@sovereign> <CAGFdkHQAi5+JxWmLTqB8O3xW+BkE_EB+=XqV5TOs+KAkd0RoqQ@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <CAGFdkHQAi5+JxWmLTqB8O3xW+BkE_EB+=XqV5TOs+KAkd0RoqQ@mail.gmail.com> Subject: Re: [dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Tue, Mar 23, 2021 at 07:22:00AM +0100, Gabriel Ganne wrote: > Hi, > Thanks for the review. > I have some reservations about those TODO: they are about > rewriting the same functionality with a newer meson feature. > No functional change is expected. => Why not write a commit that > implements such a TODO and bumps meson version at the same time > independently ? > In any case, I aimed to set meson's required version to the lowest > possible value > so that distributions would have a chance to provide it. I know we can > just > install meson using pip, but it might be nice not to need this. > Below are some versions of meson packages as of today: > pip: 0.57.1 > rhel-8: 0.49.2 > debian-10: 0.49.2 > ubuntu-18.04: 0.45.1 > ubuntu-20.04: 0.53.2 > Going over 0.49.2 will cause DPDK to lose some major distribution's > stable release, > at least out-of-the-box through their respective package manager. > I propose to bump to 0.49.2 here, and leave the TODOs to wait a little > longer. +1 However, I don't think we need the ".2" specifically, since new features don't come in point releases, so I'd suggest just making "0.49" the minimum.