From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30141A09E4; Tue, 23 Mar 2021 10:42:02 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B45284014D; Tue, 23 Mar 2021 10:42:01 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 7B46440143 for ; Tue, 23 Mar 2021 10:42:00 +0100 (CET) IronPort-SDR: vw/xW649U7g8QWjCZF1bvMhfoLWeCokBPI7S0UsTrnX36I5sfIZ4kctdnSDW10AO/SwWUYhoVs eDQiazHSZdbQ== X-IronPort-AV: E=McAfee;i="6000,8403,9931"; a="190469918" X-IronPort-AV: E=Sophos;i="5.81,271,1610438400"; d="scan'208";a="190469918" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2021 02:41:59 -0700 IronPort-SDR: Ld2H9zMGTri+0MZ32VUTSCbIexSwWE2hma1DGRovquhiCAxVokvRHhx3StpfMOgzDGxXBOLZKF kvGEz3d70REw== X-IronPort-AV: E=Sophos;i="5.81,271,1610438400"; d="scan'208";a="408239993" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.26.170]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 23 Mar 2021 02:41:56 -0700 Date: Tue, 23 Mar 2021 09:41:52 +0000 From: Bruce Richardson To: Gabriel Ganne Cc: Aaron Conole , Michael Santana , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , dev@dpdk.org, olivier.matz@6wind.com, thierry.herbelot@6wind.com Message-ID: <20210323094152.GB1158@bricha3-MOBL.ger.corp.intel.com> References: <20210322140609.7564-1-gabriel.ganne@6wind.com> <20210323083619.23463-1-gabriel.ganne@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210323083619.23463-1-gabriel.ganne@6wind.com> Subject: Re: [dpdk-dev] [PATCH v3] meson: update minimum required meson version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Mar 23, 2021 at 09:36:18AM +0100, Gabriel Ganne wrote: > Bump meson required version to 0.49.2 which is chosen to be the same as > in both redhat-8 and debian-10. > > Update documentation and travis setup script accordingly. > > This fixes the following warning: > WARNING: Project targeting '>= 0.47.1' but tried to use feature introduced > in '0.48.0': console arg in custom_target > > 'console' argument is used within kernel/linux/kni/meson.build > > Signed-off-by: Gabriel Ganne Repeating here the comment I had on earlier thread - I'd drop the ".2" when not necessary, i.e. unless we find there are bugs that cause us issues with 0.49 or 0.49.1. In general I think it's better to keep the required meson version only at the major release level. The reason it's currently at 0.47.1 rather than 0.47, was that 0.47 had a bug that prevented DPDK builds from working correctly. Regards, /Bruce