From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DAC17A034F; Tue, 23 Mar 2021 08:42:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 729AF4014D; Tue, 23 Mar 2021 08:42:47 +0100 (CET) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by mails.dpdk.org (Postfix) with ESMTP id B5C8C40143 for ; Tue, 23 Mar 2021 08:42:45 +0100 (CET) Received: by mail-lf1-f42.google.com with SMTP id b4so1282542lfi.6 for ; Tue, 23 Mar 2021 00:42:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GSuXWT31z4cBlXhLR0MrI5l7l/95itRtIrsm/9gVHJ0=; b=tUuHf5I3bdbOz4Yx/um/uJBb2J7vNzcycf+D6nFyd76QAvZvOdIJCPhpk+0SzZ6tHL fzFzt0qGC+WZMeOOfKGcv2Jh9fYt4R6YjXHhLLR/jsN8fs+OT9tkS9OFFYWTRhEiSQP0 moA4C3SrE46yL01xbK4d5troCHw95Sv+HQQVJyA0ev6sDqODxf/KzARB+kimvJUcyPP0 oS+xferT1UC2BMRVisqTHdj71u+eSPXZCxOX4qGI4KwGvryndALZhziD5ZpmjLKH0kZE RgiQsO+JWhMed9RyTezyVTGBJ3rN5Hja7uA63ctPtg8QSIp8Q5OaQf0LnB6YKSvsq6Gg o37Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GSuXWT31z4cBlXhLR0MrI5l7l/95itRtIrsm/9gVHJ0=; b=FjjiNN0POPvQSQd2L8DuTCaYEiEYojtRuhibz4p8XVrFKicBuYYgxF77/47KRV1hBs vxKk8lklocOjf96os63rq8kOV0tfjxkRyol11H9tsZacI+Ydwdi+Ab2Pizdp5d3GteZu FPBMZm4A0651EudE98+EDTi45jEZBbfR4FCZPkCja7cZjn10d8RycRoaYD08gyHfdIx9 KdTViDxgxrg/bS6XD4/u0zqnAw8ykyU1GCbWMGjMkH+7I5s8gCdu2sMp3hoY3RHoPOT0 5taHqUP7wvsvwME1+61HejJzQMT+Z8E5ZzuXJ7pcNTCyC9r15jLMyVP6/kmpRdtCZtCJ vo+g== X-Gm-Message-State: AOAM533KeNRDwyWUZhRSlTWXtLye30oxsgWVKn6oLFQHqh49KVY0cepF 14MaCo9FIpceaPy1HysWB2A= X-Google-Smtp-Source: ABdhPJytuO1818HDgmvT7+p/MSX88lJPnS1xh1Bg8mvCXCzF92HSrZFj+W00kdNwSmRJ76frJQCPlQ== X-Received: by 2002:a05:6512:3702:: with SMTP id z2mr1964040lfr.505.1616485365164; Tue, 23 Mar 2021 00:42:45 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id e25sm2232504ljo.113.2021.03.23.00.42.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 00:42:44 -0700 (PDT) Date: Tue, 23 Mar 2021 10:42:43 +0300 From: Dmitry Kozlyuk To: Gabriel Ganne Cc: Bruce Richardson , dev@dpdk.org, Olivier Matz , Thierry Herbelot Message-ID: <20210323104243.11a4629c@sovereign> In-Reply-To: References: <20210322083901.22493-1-gabriel.ganne@6wind.com> <20210322093421.GA1440@bricha3-MOBL.ger.corp.intel.com> <20210322182557.4dd1261b@sovereign> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-03-23 07:22 (UTC+0100), Gabriel Ganne: > Hi, > > Thanks for the review. > > I have some reservations about those TODO: they are about > rewriting the same functionality with a newer meson feature. > No functional change is expected. => Why not write a commit that > implements such a TODO and bumps meson version at the same time > independently ? > > In any case, I aimed to set meson's required version to the lowest possible > value > so that distributions would have a chance to provide it. I know we can just > install meson using pip, but it might be nice not to need this. > Below are some versions of meson packages as of today: > pip: 0.57.1 > rhel-8: 0.49.2 > debian-10: 0.49.2 > ubuntu-18.04: 0.45.1 > ubuntu-20.04: 0.53.2 > > Going over 0.49.2 will cause DPDK to lose some major distribution's stable > release, > at least out-of-the-box through their respective package manager. > > I propose to bump to 0.49.2 here, and leave the TODOs to wait a little > longer. > What do you think ? Yes, sounds practical. I rather meant to recollect known TODOs then to propose solving all at once.