From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F065A0562; Tue, 23 Mar 2021 10:57:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 44B844014D; Tue, 23 Mar 2021 10:57:39 +0100 (CET) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by mails.dpdk.org (Postfix) with ESMTP id D02A740143 for ; Tue, 23 Mar 2021 10:57:37 +0100 (CET) Received: by mail-lf1-f53.google.com with SMTP id q29so25573991lfb.4 for ; Tue, 23 Mar 2021 02:57:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Z6ys1JFiSAKWnk8LiW8i0G4YrZNbCv0ler/CRtZZ0nk=; b=G/iZ2vFN+BN4xWAoJQ92cYoy8ShLnJtYguEYK46W6KWH45ufD26KO1PBpfiO46sUIB Kuw30V9eIRATTzac380Kq4UQ5Ybc+hVLeAhoYgCtJ7s/K+95xOIVlq2yVIMK203oz84e ET512NNMR7IsPlnN2qFE+Yixw7iCDAWPw+2dKBGm2ET1klk3NJ7LpC8pdwyuf6/n8N7C jz1mNdNijoUrM61ySPDfUgNO+mTub3MX2fioLv0FEByoKhzAoDds/Im5uRmy7OCZXXe7 sSXnuMVk7Y7r+KZ0ZeL4Rd7E6DoOy3NTeFOqB2E3OVSIJXYOdwzH0IsOcwmbEgoAp2Y0 PgUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Z6ys1JFiSAKWnk8LiW8i0G4YrZNbCv0ler/CRtZZ0nk=; b=T5d/JzuvK95kjH6vK3+p0eWHrlhvc4ns4PVv0lyIQr1pZgtOCHz/BpxiKIYVZiNJsw 55VdgZoBKy3PKjLGXbCCk9GRrDa7xK20tV6OiW8XbKQ5clyfi8rTozDHYgn2mNsueh9L YfA221h+Q8Flnb0zsVDOIgJ0QIV79x7bwtYwV4b+126vGG3jCsWY9skyNkk/6CWCUnJ3 dKKEOL6G+CUU+UEYHmnd7vTGKUi3H6ERETQ1lY66hoPoVSLReIrdQYlxggOOldDnzgD/ YyUMtQTG7ii1DlTk61Hbda4zaUc0Gb/pi7oMj6kJlHZPtyvAueWdndSOu2MEQnKIagBB 8smQ== X-Gm-Message-State: AOAM53141Cd6lbHuRglL5y3K2xMPfVBqFNVzgxrDlcvWYejuCbh5bRzb /S5OqJex4isjwBMaPxD8X0U= X-Google-Smtp-Source: ABdhPJyWOkMmDA7mzPXclh90b4RVm9ePuUVK4jhRNHfWptvmZvyq3gAYTO6uPGRBhK5hKH3r/MHpVg== X-Received: by 2002:a19:2216:: with SMTP id i22mr2122115lfi.57.1616493457387; Tue, 23 Mar 2021 02:57:37 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id i7sm2273277lja.15.2021.03.23.02.57.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 02:57:36 -0700 (PDT) Date: Tue, 23 Mar 2021 12:57:35 +0300 From: Dmitry Kozlyuk To: "Kinsella, Ray" Cc: Xueming Li , dev@dpdk.org, Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Neil Horman Message-ID: <20210323125735.0e5c243d@sovereign> In-Reply-To: <9acf308d-c73f-2063-5b6d-3fb4fc601c76@ashroe.eu> References: <20210316124520.19726-1-xuemingl@nvidia.com> <20210323023239.2687be4e@sovereign> <2fbc5945-4f00-3104-f490-2d8d87d78fc9@ashroe.eu> <9acf308d-c73f-2063-5b6d-3fb4fc601c76@ashroe.eu> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: update all buses default scan mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-03-23 09:34 (UTC+0000), Kinsella, Ray: > On 23/03/2021 09:33, Kinsella, Ray wrote: > > > > > > On 22/03/2021 23:32, Dmitry Kozlyuk wrote: > >> 2021-03-16 20:45 (UTC+0800), Xueming Li: > >> [...] > [SNIP] > >>> rte_mem_page_size; > >> > >> New function is private to EAL, so it doesn't need exporting. > >> > > > > Right - it is annotated as INTERNAL. > > > > Sorry, let me be clearer - it is being correctly annotated unless I have missed something. This function is purely internal to librte_eal. It doesn't need to be added to .map or .def. It also doesn't need __rte_internal, like other functions in eal_private.h don't need it either.