From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru,
bruce.richardson@intel.com,
Shepard Siegel <shepard.siegel@atomicrules.com>
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: introduce enable_driver_sdk to install driver headers
Date: Tue, 23 Mar 2021 21:32:38 -0700 [thread overview]
Message-ID: <20210324043238.GA31805@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <33c030de-ba1c-cfd3-da28-800f151d964f@intel.com>
On Tue, Mar 23, 2021 at 05:04:08PM +0000, Ferruh Yigit wrote:
> >diff --git a/lib/librte_ethdev/meson.build b/lib/librte_ethdev/meson.build
> >index c37b2e377..4353fa6b7 100644
> >--- a/lib/librte_ethdev/meson.build
> >+++ b/lib/librte_ethdev/meson.build
> >@@ -20,8 +20,14 @@ headers = files('rte_ethdev.h',
> > 'rte_mtr_driver.h',
> > 'rte_tm.h',
> > 'rte_tm_driver.h')
> >+
> > indirect_headers += files(
> > 'rte_ethdev_core.h',
> > 'rte_eth_ctrl.h')
> >+driver_sdk_headers += files(
> >+ 'ethdev_driver.h',
> >+ 'ethdev_pci.h',
> >+ 'ethdev_vdev.h')
> >+
> > deps += ['net', 'kvargs', 'meter', 'telemetry']
>
i feel like i missed a reply here. but just to clarify only ethdev will
be covered by this patch. inclusion of other driver headers was
discussed off list (sorry) and it emerged that it would result in
withdraw a number of driver api/abi that had not been marked as
__rte_internal.
for driver api that were being exported as 'stable' a deprecation notice
will need to be issued in order to make them part of the
driver_sdk_headers. for that reason only ethdev is being made available
under this option for now.
please ack/nack the patch as-is
thanks
next prev parent reply other threads:[~2021-03-24 4:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 19:27 [dpdk-dev] [PATCH] " Tyler Retzlaff
2021-03-12 15:19 ` Ferruh Yigit
2021-03-12 15:25 ` David Marchand
2021-03-12 15:34 ` Bruce Richardson
2021-03-12 15:52 ` Thomas Monjalon
2021-03-12 18:43 ` Tyler Retzlaff
2021-03-12 22:20 ` [dpdk-dev] [PATCH v2] " Tyler Retzlaff
2021-03-15 10:06 ` Bruce Richardson
2021-03-23 17:04 ` Ferruh Yigit
2021-03-24 4:32 ` Tyler Retzlaff [this message]
2021-03-24 11:27 ` Ferruh Yigit
2021-03-24 11:30 ` Thomas Monjalon
2021-03-24 16:24 ` Tyler Retzlaff
2021-03-26 12:02 ` Ferruh Yigit
2021-03-26 20:52 ` Tyler Retzlaff
2021-03-29 9:43 ` Ferruh Yigit
2021-03-29 12:10 ` Thomas Monjalon
2021-03-29 15:23 ` Ferruh Yigit
2021-03-29 19:31 ` Thomas Monjalon
2021-03-30 12:50 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210324043238.GA31805@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=shepard.siegel@atomicrules.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).