From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 24930A0A0A;
	Wed, 24 Mar 2021 05:32:42 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 93A16140D21;
	Wed, 24 Mar 2021 05:32:41 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id A0EED4014F
 for <dev@dpdk.org>; Wed, 24 Mar 2021 05:32:39 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id D6A6620B5680; Tue, 23 Mar 2021 21:32:38 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D6A6620B5680
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1616560358;
 bh=eBxix1O+BzX1teCgVaIfFPbW0P/Yxjlhyj+1Xwd85yw=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=U3GYdvaafWOdjrBwtAuqyxbrk2v0vFiBgf0qgOB5AK6APGxCB+erwPO4Wb2uIJbJN
 NFwUHNSZUJYAmQ0+8sskNGBk0BoXbD0Z3S7Wq7Mj145X81M+T+8hyAVOPrsdhKYPhm
 Tw95hWTsE0/BZynG0uSYW/3ft+uxun0uTDGkhCJg=
Date: Tue, 23 Mar 2021 21:32:38 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru,
 bruce.richardson@intel.com, Shepard Siegel <shepard.siegel@atomicrules.com>
Message-ID: <20210324043238.GA31805@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1615490833-23052-1-git-send-email-roretzla@linux.microsoft.com>
 <1615587606-29329-1-git-send-email-roretzla@linux.microsoft.com>
 <33c030de-ba1c-cfd3-da28-800f151d964f@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <33c030de-ba1c-cfd3-da28-800f151d964f@intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: introduce enable_driver_sdk to
 install driver headers
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Mar 23, 2021 at 05:04:08PM +0000, Ferruh Yigit wrote:
> >diff --git a/lib/librte_ethdev/meson.build b/lib/librte_ethdev/meson.build
> >index c37b2e377..4353fa6b7 100644
> >--- a/lib/librte_ethdev/meson.build
> >+++ b/lib/librte_ethdev/meson.build
> >@@ -20,8 +20,14 @@ headers = files('rte_ethdev.h',
> >  	'rte_mtr_driver.h',
> >  	'rte_tm.h',
> >  	'rte_tm_driver.h')
> >+
> >  indirect_headers += files(
> >  	'rte_ethdev_core.h',
> >  	'rte_eth_ctrl.h')
> >+driver_sdk_headers += files(
> >+	'ethdev_driver.h',
> >+	'ethdev_pci.h',
> >+	'ethdev_vdev.h')
> >+
> >  deps += ['net', 'kvargs', 'meter', 'telemetry']
> 

i feel like i missed a reply here.  but just to clarify only ethdev will
be covered by this patch. inclusion of other driver headers was
discussed off list (sorry) and it emerged that it would result in
withdraw a number of driver api/abi that had not been marked as
__rte_internal.

for driver api that were being exported as 'stable' a deprecation notice
will need to be issued in order to make them part of the
driver_sdk_headers. for that reason only ethdev is being made available
under this option for now.

please ack/nack the patch as-is

thanks