From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1619A0A02; Wed, 24 Mar 2021 17:24:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD5CB140F2F; Wed, 24 Mar 2021 17:24:44 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id B333C140F2E for ; Wed, 24 Mar 2021 17:24:42 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 01E3620B5680; Wed, 24 Mar 2021 09:24:42 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 01E3620B5680 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1616603082; bh=cSY+X4UPkFmhDpLUC2Qe1s1tMrZDtS1A8vJKe0jHgqA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UVNdrv7s6UQO0wPs4CyDUElqUN78/RSXp1dKy96WmiwZn1FO3wpBYzu+dgNGaFvXB aKDo+PesksgqbYEwqU4dUb8A2uMe506oPL/PbT3j2MzjcSBFwacDi1uBn7Ogqo3OIr e298YyvkRTpCliiPyRWZQMLNl3a+VIasxB5mPvyE= Date: Wed, 24 Mar 2021 09:24:41 -0700 From: Tyler Retzlaff To: Thomas Monjalon Cc: Ferruh Yigit , dev@dpdk.org, andrew.rybchenko@oktetlabs.ru, bruce.richardson@intel.com, Shepard Siegel , David Marchand Message-ID: <20210324162441.GA14991@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1615490833-23052-1-git-send-email-roretzla@linux.microsoft.com> <20210324043238.GA31805@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <7e48bf43-5bee-045e-aef2-f56dc72d8736@intel.com> <5945384.p3lA8Brad8@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5945384.p3lA8Brad8@thomas> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [PATCH v2] ethdev: introduce enable_driver_sdk to install driver headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Mar 24, 2021 at 12:30:36PM +0100, Thomas Monjalon wrote: > 24/03/2021 12:27, Ferruh Yigit: > > > > But not sure how to manage the same problem for whole project, if install all > > headers in one patch, or add them gradually via separate patches by time ... > > We did a cleanup in ethdev but not in other driver classes. > When the cleanup will be done gradually, the headers > must move in this new category driver_sdk_headers. yes, some headers are not installed now. so they need only to have their api marked __rte_internal and installed (since there should be no external consumer as a function of not being installed) the more difficult case is where headers were installed but the api were not marked __rte_internal and appear in the stable version.map. for those i guess deprecation notice has to be issued before marking as internal.