From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 341D9A0A02; Thu, 25 Mar 2021 01:09:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A11594067B; Thu, 25 Mar 2021 01:09:44 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 87FA840147 for ; Thu, 25 Mar 2021 01:09:43 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id C509B20B5680; Wed, 24 Mar 2021 17:09:42 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C509B20B5680 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1616630982; bh=I2HjkFDawW+JmNFa5xAqZmPb9syGuOk2qzUv1PFP/ks=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hyR6IQrCfhPUUK99Boex8m/fT9+NhrV+7glqvx143TORDsOnL0ZQH5LEl9ccWXfw9 9GPkSuRkdRrWyln/6V86N4dmzPeRwSRjPIW4Pq3x/qVCA6Wj+Y5RAF6y5Mw7g+OH/+ 9uTEcGaGfztuspvB0x2RlQXX4bqS5ASfdjGMfT1k= Date: Wed, 24 Mar 2021 17:09:42 -0700 From: Tyler Retzlaff To: Dmitry Kozlyuk Cc: Thomas Monjalon , dev@dpdk.org, david.marchand@redhat.com, bruce.richardson@intel.com, stephen@networkplumber.org, drc@linux.vnet.ibm.com Message-ID: <20210325000942.GA22319@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1616560011-31647-1-git-send-email-roretzla@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <6578330.zVv2phWGOd@thomas> <20210324172841.GC14991@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <11634428.8dEGKDZn2b@thomas> <20210324215548.GA2272@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20210325014147.2a2f5749@sovereign> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210325014147.2a2f5749@sovereign> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [PATCH] eal: standard c++ forbids defining the keyword asm as a macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Mar 25, 2021 at 01:41:47AM +0300, Dmitry Kozlyuk wrote: > 2021-03-24 14:55 (UTC-0700), Tyler Retzlaff: > > Can't speak for Seastar and Click, but we never hit this particular issue. > What is the minimal complete example to reproduce? interesting, i did a bit more digging and it is clear why. i'm consuming headers and crt that have been enhanced to enforce c++ standards compliance. after dumping the preprocessed output i suspect this cannot be reproduced with the publicly available headers it seems i'm the only "beneficiary" heh. so the minimal example is really just to #include after including say rte_windows.h but it won't reproduce for public users of the sdk. if there is a great deal of concern with respect to compatibility i guess as the single consumer who has this problem i can just #undef asm since we don't use inline asm anyway. thoughts?