DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-dev] [PATCH v2 0/4] telemetry logging improvements and cleanup
Date: Thu, 25 Mar 2021 13:57:03 +0000	[thread overview]
Message-ID: <20210325135707.325536-1-bruce.richardson@intel.com> (raw)
In-Reply-To: <20210310172430.412405-1-bruce.richardson@intel.com>

This set adds support for using the regular rte_log functions from the telemetry
library; avoiding circular dependencies by having EAL register the telemetry
library itself and then passing the required handles to that library as part of
the telemetry_init call.

Beyond this change, the other three patches are cleanups to ensure that all
internal functions are clearly separate from the public APIs. (Patches 3 & 4 may
be merged into a single one on apply, for I've kept them separate for now for
clarity).

V2: Rebased on latest main branch.

Bruce Richardson (4):
  telemetry: use rte_log for logging
  telemetry: make the legacy registration function internal
  telemetry: rename internal-only header file
  telemetry: move init function to internal header

 doc/guides/rel_notes/release_21_05.rst        |  5 ++
 lib/librte_eal/freebsd/eal.c                  | 12 +--
 lib/librte_eal/linux/eal.c                    | 12 +--
 lib/librte_metrics/rte_metrics_telemetry.c    |  2 +-
 lib/librte_telemetry/rte_telemetry.h          | 25 ------
 lib/librte_telemetry/telemetry.c              | 76 +++++++++----------
 ...elemetry_legacy.h => telemetry_internal.h} | 41 +++++++++-
 lib/librte_telemetry/telemetry_legacy.c       |  2 +-
 lib/librte_telemetry/version.map              |  2 +-
 9 files changed, 87 insertions(+), 90 deletions(-)
 rename lib/librte_telemetry/{rte_telemetry_legacy.h => telemetry_internal.h} (65%)

--
2.27.0


  parent reply	other threads:[~2021-03-25 13:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 17:24 [dpdk-dev] [PATCH " Bruce Richardson
2021-03-10 17:24 ` [dpdk-dev] [PATCH 1/4] telemetry: use rte_log for logging Bruce Richardson
2021-03-11 12:50   ` Power, Ciara
2021-03-10 17:24 ` [dpdk-dev] [PATCH 2/4] telemetry: make the legacy registration function internal Bruce Richardson
2021-03-11 12:50   ` Power, Ciara
2021-03-10 17:24 ` [dpdk-dev] [PATCH 3/4] telemetry: create internal-only header file Bruce Richardson
2021-03-11 12:51   ` Power, Ciara
2021-03-10 17:24 ` [dpdk-dev] [PATCH 4/4] telemetry: move init function to internal header Bruce Richardson
2021-03-11 12:51   ` Power, Ciara
2021-03-24 21:11 ` [dpdk-dev] [PATCH 0/4] telemetry logging improvements and cleanup Thomas Monjalon
2021-03-25  8:55   ` Bruce Richardson
2021-03-25 13:57 ` Bruce Richardson [this message]
2021-03-25 13:57   ` [dpdk-dev] [PATCH v2 1/4] telemetry: use rte_log for logging Bruce Richardson
2021-03-25 14:09     ` David Marchand
2021-03-25 14:16       ` Bruce Richardson
2021-03-25 13:57   ` [dpdk-dev] [PATCH v2 2/4] telemetry: make the legacy registration function internal Bruce Richardson
2021-03-25 13:57   ` [dpdk-dev] [PATCH v2 3/4] telemetry: rename internal-only header file Bruce Richardson
2021-03-25 13:57   ` [dpdk-dev] [PATCH v2 4/4] telemetry: move init function to internal header Bruce Richardson
2021-03-25 16:36   ` [dpdk-dev] [PATCH v2 0/4] telemetry logging improvements and cleanup Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210325135707.325536-1-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).