From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 87C47A0A02;
	Thu, 25 Mar 2021 19:50:28 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 17034140F2E;
	Thu, 25 Mar 2021 19:50:28 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id F189A140F09
 for <dev@dpdk.org>; Thu, 25 Mar 2021 19:50:26 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 346412099AB0; Thu, 25 Mar 2021 11:50:26 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 346412099AB0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1616698226;
 bh=V4LDGtXfFI/QWOO20MiGCFE7G1TvPrF+D3DnclKzWTA=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=UQ+rtMIS0V47fMvlEZWlCtbkFDKNkxz4jQZ+X3N5/V/WyMbqXRoBY8fx2QkU2Vw/2
 tfX6g3LYbib+qr0wAb4MVaHSMKhCbz+el+ZyOgdMiQ1PqvNdhF1LSSczLP3/fRRW+5
 c9JBjXb90pK34FcqJ+qnx7Oj1mIxt4CpwQdHMW6k=
Date: Thu, 25 Mar 2021 11:50:26 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, dev@dpdk.org,
 david.marchand@redhat.com, bruce.richardson@intel.com,
 stephen@networkplumber.org, drc@linux.vnet.ibm.com
Message-ID: <20210325185026.GA11101@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1616560011-31647-1-git-send-email-roretzla@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
 <20210325014147.2a2f5749@sovereign>
 <20210325000942.GA22319@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
 <6471682.gLmPldMPvt@thomas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6471682.gLmPldMPvt@thomas>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH] eal: standard c++ forbids defining the
 keyword asm as a macro
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Mar 25, 2021 at 09:00:54AM +0100, Thomas Monjalon wrote:
> 25/03/2021 01:09, Tyler Retzlaff:
> > On Thu, Mar 25, 2021 at 01:41:47AM +0300, Dmitry Kozlyuk wrote:
> > > 2021-03-24 14:55 (UTC-0700), Tyler Retzlaff:
> > > 
> > > Can't speak for Seastar and Click, but we never hit this particular issue.
> > > What is the minimal complete example to reproduce?
> > 
> > interesting, i did a bit more digging and it is clear why. i'm consuming
> > headers and crt that have been enhanced to enforce c++ standards
> > compliance. after dumping the preprocessed output i suspect this cannot
> > be reproduced with the publicly available headers it seems i'm the only
> > "beneficiary" heh.
> > 
> > so the minimal example is really just to #include <list> after including
> > say rte_windows.h but it won't reproduce for public users of the sdk.
> > 
> > if there is a great deal of concern with respect to compatibility i
> > guess as the single consumer who has this problem i can just #undef asm
> > since we don't use inline asm anyway.
> > 
> > thoughts?
> 
> No please don't do this.
> There is an issue in DPDK which must be fixed.
> It seems your patch is correct, I am waiting for confirmation of others.
> 

thanks, i'm glad for the desire to make the proper fix. we'll wait for
others to comment.