* [dpdk-dev] [PATCH] telemetry: cleanup internal header
@ 2021-03-26 8:24 David Marchand
2021-03-26 9:32 ` Thomas Monjalon
2021-03-26 16:16 ` David Marchand
0 siblings, 2 replies; 5+ messages in thread
From: David Marchand @ 2021-03-26 8:24 UTC (permalink / raw)
To: dev; +Cc: Ciara Power, Bruce Richardson
The experimental banner can be removed.
Every in-tree file is compiled with _GNU_SOURCE, so RTE_HAS_CPUSET is
unneeded for an internal header.
Fixes: 0e64ae618e10 ("telemetry: move init function to internal header")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/librte_telemetry/rte_telemetry.h | 1 -
lib/librte_telemetry/telemetry_internal.h | 9 ++-------
2 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/lib/librte_telemetry/rte_telemetry.h b/lib/librte_telemetry/rte_telemetry.h
index fd57718c26..031db9e968 100644
--- a/lib/librte_telemetry/rte_telemetry.h
+++ b/lib/librte_telemetry/rte_telemetry.h
@@ -6,7 +6,6 @@
#include <sched.h>
#include <rte_compat.h>
-#include <rte_os.h>
#ifndef _RTE_TELEMETRY_H_
#define _RTE_TELEMETRY_H_
diff --git a/lib/librte_telemetry/telemetry_internal.h b/lib/librte_telemetry/telemetry_internal.h
index 6c52006040..d085c492dc 100644
--- a/lib/librte_telemetry/telemetry_internal.h
+++ b/lib/librte_telemetry/telemetry_internal.h
@@ -6,13 +6,12 @@
#define _RTE_TELEMETRY_INTERNAL_H_
#include <rte_compat.h>
+#include <rte_os.h>
#include "rte_telemetry.h"
/**
* @internal
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
-
+ *
* @file
* RTE Telemetry Legacy and internal definitions
*
@@ -84,8 +83,6 @@ rte_telemetry_legacy_register(const char *cmd,
enum rte_telemetry_legacy_data_req data_req,
telemetry_legacy_cb fn);
-#ifdef RTE_HAS_CPUSET
-
/**
* @internal
* Log function type, to allow passing as parameter if necessary
@@ -115,6 +112,4 @@ int
rte_telemetry_init(const char *runtime_dir, const char *rte_version, rte_cpuset_t *cpuset,
rte_log_fn log_fn, uint32_t registered_logtype);
-#endif /* RTE_HAS_CPUSET */
-
#endif
--
2.23.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] telemetry: cleanup internal header
2021-03-26 8:24 [dpdk-dev] [PATCH] telemetry: cleanup internal header David Marchand
@ 2021-03-26 9:32 ` Thomas Monjalon
2021-03-26 10:32 ` Bruce Richardson
2021-03-26 16:16 ` David Marchand
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Monjalon @ 2021-03-26 9:32 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Ciara Power, Bruce Richardson
26/03/2021 09:24, David Marchand:
> The experimental banner can be removed.
> Every in-tree file is compiled with _GNU_SOURCE, so RTE_HAS_CPUSET is
> unneeded for an internal header.
>
> Fixes: 0e64ae618e10 ("telemetry: move init function to internal header")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
good catches, thank you
Acked-by: Thomas Monjalon <thomas@monjalon.net>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] telemetry: cleanup internal header
2021-03-26 9:32 ` Thomas Monjalon
@ 2021-03-26 10:32 ` Bruce Richardson
2021-03-26 11:03 ` Power, Ciara
0 siblings, 1 reply; 5+ messages in thread
From: Bruce Richardson @ 2021-03-26 10:32 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: David Marchand, dev, Ciara Power
On Fri, Mar 26, 2021 at 10:32:03AM +0100, Thomas Monjalon wrote:
> 26/03/2021 09:24, David Marchand:
> > The experimental banner can be removed.
> > Every in-tree file is compiled with _GNU_SOURCE, so RTE_HAS_CPUSET is
> > unneeded for an internal header.
> >
> > Fixes: 0e64ae618e10 ("telemetry: move init function to internal header")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> good catches, thank you
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>
+1 thanks.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] telemetry: cleanup internal header
2021-03-26 10:32 ` Bruce Richardson
@ 2021-03-26 11:03 ` Power, Ciara
0 siblings, 0 replies; 5+ messages in thread
From: Power, Ciara @ 2021-03-26 11:03 UTC (permalink / raw)
To: Richardson, Bruce, Thomas Monjalon; +Cc: David Marchand, dev
>-----Original Message-----
>From: Richardson, Bruce <bruce.richardson@intel.com>
>Sent: Friday 26 March 2021 10:32
>To: Thomas Monjalon <thomas@monjalon.net>
>Cc: David Marchand <david.marchand@redhat.com>; dev@dpdk.org; Power,
>Ciara <ciara.power@intel.com>
>Subject: Re: [dpdk-dev] [PATCH] telemetry: cleanup internal header
>
>On Fri, Mar 26, 2021 at 10:32:03AM +0100, Thomas Monjalon wrote:
>> 26/03/2021 09:24, David Marchand:
>> > The experimental banner can be removed.
>> > Every in-tree file is compiled with _GNU_SOURCE, so RTE_HAS_CPUSET
>> > is unneeded for an internal header.
>> >
>> > Fixes: 0e64ae618e10 ("telemetry: move init function to internal
>> > header")
>> >
>> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>>
>> good catches, thank you
>>
>> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>>
>+1 thanks.
>Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Thanks David,
Acked-by: Ciara Power <ciara.power@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] telemetry: cleanup internal header
2021-03-26 8:24 [dpdk-dev] [PATCH] telemetry: cleanup internal header David Marchand
2021-03-26 9:32 ` Thomas Monjalon
@ 2021-03-26 16:16 ` David Marchand
1 sibling, 0 replies; 5+ messages in thread
From: David Marchand @ 2021-03-26 16:16 UTC (permalink / raw)
To: dev, Thomas Monjalon; +Cc: Ciara Power, Bruce Richardson
On Fri, Mar 26, 2021 at 9:25 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> The experimental banner can be removed.
> Every in-tree file is compiled with _GNU_SOURCE, so RTE_HAS_CPUSET is
> unneeded for an internal header.
>
> Fixes: 0e64ae618e10 ("telemetry: move init function to internal header")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Ciara Power <ciara.power@intel.com>
Applied.
--
David Marchand
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-26 16:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-26 8:24 [dpdk-dev] [PATCH] telemetry: cleanup internal header David Marchand
2021-03-26 9:32 ` Thomas Monjalon
2021-03-26 10:32 ` Bruce Richardson
2021-03-26 11:03 ` Power, Ciara
2021-03-26 16:16 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).