DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] drivers: add missing headers
@ 2021-03-26 16:46 Ferruh Yigit
  2021-04-13 10:04 ` Ferruh Yigit
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Ferruh Yigit @ 2021-03-26 16:46 UTC (permalink / raw)
  To: Gagandeep Singh, Hemant Agrawal, Jerin Jacob, Rasesh Mody,
	Shahed Shaikh, Jeff Guo, Haiyue Wang, Stephen Hemminger, Long Li,
	Martin Spinler, Andrew Rybchenko, Yong Wang
  Cc: Ferruh Yigit, dev

These headers are used but not included explicitly, including them.

"arpa/inet.h" is included for 'htons' and friends.
"netinet/in.h" is included for 'IPPROTO_IP'.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 drivers/crypto/dpaa_sec/dpaa_sec.c    | 1 +
 drivers/event/octeontx/ssovf_worker.h | 2 ++
 drivers/net/bnx2x/bnx2x.c             | 1 +
 drivers/net/igc/igc_ethdev.h          | 1 +
 drivers/net/igc/igc_txrx.c            | 1 +
 drivers/net/netvsc/hn_ethdev.c        | 1 +
 drivers/net/nfb/nfb_rx.h              | 1 +
 drivers/net/pcap/rte_eth_pcap.c       | 1 +
 drivers/net/pfe/pfe_hal.c             | 2 ++
 drivers/net/pfe/pfe_hif.c             | 1 +
 drivers/net/sfc/sfc_tso.h             | 2 ++
 drivers/net/vmxnet3/vmxnet3_ethdev.h  | 1 +
 12 files changed, 15 insertions(+)

diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c
index a4c4b094bbfa..43363ba6badd 100644
--- a/drivers/crypto/dpaa_sec/dpaa_sec.c
+++ b/drivers/crypto/dpaa_sec/dpaa_sec.c
@@ -20,6 +20,7 @@
 #endif
 #include <rte_cycles.h>
 #include <rte_dev.h>
+#include <rte_ip.h>
 #include <rte_kvargs.h>
 #include <rte_malloc.h>
 #include <rte_mbuf.h>
diff --git a/drivers/event/octeontx/ssovf_worker.h b/drivers/event/octeontx/ssovf_worker.h
index 6b2fb9b81741..4354f007d7e0 100644
--- a/drivers/event/octeontx/ssovf_worker.h
+++ b/drivers/event/octeontx/ssovf_worker.h
@@ -2,6 +2,8 @@
  * Copyright(c) 2017 Cavium, Inc
  */
 
+#include <arpa/inet.h>
+
 #include <rte_common.h>
 #include <rte_branch_prediction.h>
 
diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index 8eb6d609bdc3..654878d9dee8 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -23,6 +23,7 @@
 
 #include <sys/types.h>
 #include <sys/stat.h>
+#include <arpa/inet.h>
 #include <fcntl.h>
 #include <zlib.h>
 #include <rte_bitops.h>
diff --git a/drivers/net/igc/igc_ethdev.h b/drivers/net/igc/igc_ethdev.h
index a09debfb40c7..c1f0d057c9a7 100644
--- a/drivers/net/igc/igc_ethdev.h
+++ b/drivers/net/igc/igc_ethdev.h
@@ -6,6 +6,7 @@
 #define _IGC_ETHDEV_H_
 
 #include <rte_ethdev.h>
+#include <rte_flow.h>
 
 #include "base/igc_osdep.h"
 #include "base/igc_hw.h"
diff --git a/drivers/net/igc/igc_txrx.c b/drivers/net/igc/igc_txrx.c
index c0a5d5e84f7b..9f73ab006f98 100644
--- a/drivers/net/igc/igc_txrx.c
+++ b/drivers/net/igc/igc_txrx.c
@@ -3,6 +3,7 @@
  */
 
 #include <rte_config.h>
+#include <rte_flow.h>
 #include <rte_malloc.h>
 #include <ethdev_driver.h>
 #include <rte_net.h>
diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index 04904b151441..eadae6fcbb35 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -12,6 +12,7 @@
 #include <dirent.h>
 #include <net/if.h>
 #include <net/if_arp.h>
+#include <netinet/in.h>
 #include <sys/ioctl.h>
 
 #include <rte_ethdev.h>
diff --git a/drivers/net/nfb/nfb_rx.h b/drivers/net/nfb/nfb_rx.h
index 27a2888a75c5..c9708259af17 100644
--- a/drivers/net/nfb/nfb_rx.h
+++ b/drivers/net/nfb/nfb_rx.h
@@ -11,6 +11,7 @@
 #include <nfb/ndp.h>
 
 #include <rte_mbuf.h>
+#include <rte_mbuf_dyn.h>
 #include <rte_ethdev.h>
 
 #define NFB_TIMESTAMP_FLAG (1 << 0)
diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c
index 28a5027315e2..ef50d088f354 100644
--- a/drivers/net/pcap/rte_eth_pcap.c
+++ b/drivers/net/pcap/rte_eth_pcap.c
@@ -24,6 +24,7 @@
 #include <rte_kvargs.h>
 #include <rte_malloc.h>
 #include <rte_mbuf.h>
+#include <rte_mbuf_dyn.h>
 #include <rte_bus_vdev.h>
 #include <rte_string_fns.h>
 
diff --git a/drivers/net/pfe/pfe_hal.c b/drivers/net/pfe/pfe_hal.c
index 0d25ec05232b..41d783dbfff2 100644
--- a/drivers/net/pfe/pfe_hal.c
+++ b/drivers/net/pfe/pfe_hal.c
@@ -2,6 +2,8 @@
  * Copyright 2018-2019 NXP
  */
 
+#include <arpa/inet.h>
+
 #include "pfe_logs.h"
 #include "pfe_mod.h"
 
diff --git a/drivers/net/pfe/pfe_hif.c b/drivers/net/pfe/pfe_hif.c
index be5b2ada16d1..c4a7154ba732 100644
--- a/drivers/net/pfe/pfe_hif.c
+++ b/drivers/net/pfe/pfe_hif.c
@@ -7,6 +7,7 @@
 #include <sys/ioctl.h>
 #include <sys/epoll.h>
 #include <sys/eventfd.h>
+#include <arpa/inet.h>
 
 static int
 pfe_hif_alloc_descr(struct pfe_hif *hif)
diff --git a/drivers/net/sfc/sfc_tso.h b/drivers/net/sfc/sfc_tso.h
index cfc09d1645fc..f081e856e1b1 100644
--- a/drivers/net/sfc/sfc_tso.h
+++ b/drivers/net/sfc/sfc_tso.h
@@ -10,6 +10,8 @@
 #ifndef _SFC_TSO_H
 #define _SFC_TSO_H
 
+#include <rte_udp.h>
+
 #ifdef __cplusplus
 extern "C" {
 #endif
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.h b/drivers/net/vmxnet3/vmxnet3_ethdev.h
index 9d00f5d1279d..f93bb474b2cc 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.h
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.h
@@ -6,6 +6,7 @@
 #define _VMXNET3_ETHDEV_H_
 
 #include <rte_io.h>
+#include <rte_mbuf_dyn.h>
 
 #define VMXNET3_MAX_MAC_ADDRS 1
 
-- 
2.30.2


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] drivers: add missing headers
  2021-03-26 16:46 [dpdk-dev] [PATCH] drivers: add missing headers Ferruh Yigit
@ 2021-04-13 10:04 ` Ferruh Yigit
  2021-04-13 13:45   ` [dpdk-dev] [EXT] " Rasesh Mody
  2021-04-13 10:31 ` [dpdk-dev] " Andrew Rybchenko
  2021-04-13 13:15 ` Hemant Agrawal
  2 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2021-04-13 10:04 UTC (permalink / raw)
  To: Gagandeep Singh, Hemant Agrawal, Jerin Jacob, Rasesh Mody,
	Shahed Shaikh, Jeff Guo, Haiyue Wang, Stephen Hemminger, Long Li,
	Martin Spinler, Andrew Rybchenko, Yong Wang
  Cc: dev

On 3/26/2021 4:46 PM, Ferruh Yigit wrote:
> These headers are used but not included explicitly, including them.
> 
> "arpa/inet.h" is included for 'htons' and friends.
> "netinet/in.h" is included for 'IPPROTO_IP'.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Any comment/review?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] drivers: add missing headers
  2021-03-26 16:46 [dpdk-dev] [PATCH] drivers: add missing headers Ferruh Yigit
  2021-04-13 10:04 ` Ferruh Yigit
@ 2021-04-13 10:31 ` Andrew Rybchenko
  2021-04-14  9:23   ` Ferruh Yigit
  2021-04-13 13:15 ` Hemant Agrawal
  2 siblings, 1 reply; 6+ messages in thread
From: Andrew Rybchenko @ 2021-04-13 10:31 UTC (permalink / raw)
  To: Ferruh Yigit, Gagandeep Singh, Hemant Agrawal, Jerin Jacob,
	Rasesh Mody, Shahed Shaikh, Jeff Guo, Haiyue Wang,
	Stephen Hemminger, Long Li, Martin Spinler, Yong Wang
  Cc: dev

On 3/26/21 7:46 PM, Ferruh Yigit wrote:
> These headers are used but not included explicitly, including them.
> 
> "arpa/inet.h" is included for 'htons' and friends.
> "netinet/in.h" is included for 'IPPROTO_IP'.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] drivers: add missing headers
  2021-03-26 16:46 [dpdk-dev] [PATCH] drivers: add missing headers Ferruh Yigit
  2021-04-13 10:04 ` Ferruh Yigit
  2021-04-13 10:31 ` [dpdk-dev] " Andrew Rybchenko
@ 2021-04-13 13:15 ` Hemant Agrawal
  2 siblings, 0 replies; 6+ messages in thread
From: Hemant Agrawal @ 2021-04-13 13:15 UTC (permalink / raw)
  To: Ferruh Yigit, Gagandeep Singh, Hemant Agrawal, Jerin Jacob,
	Rasesh Mody, Shahed Shaikh, Jeff Guo, Haiyue Wang,
	Stephen Hemminger, Long Li, Martin Spinler, Andrew Rybchenko,
	Yong Wang
  Cc: dev

Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [EXT] Re: [PATCH] drivers: add missing headers
  2021-04-13 10:04 ` Ferruh Yigit
@ 2021-04-13 13:45   ` Rasesh Mody
  0 siblings, 0 replies; 6+ messages in thread
From: Rasesh Mody @ 2021-04-13 13:45 UTC (permalink / raw)
  To: Ferruh Yigit, Gagandeep Singh, Hemant Agrawal,
	Jerin Jacob Kollanukkaran, Shahed Shaikh, Jeff Guo, Haiyue Wang,
	Stephen Hemminger, Long Li, Martin Spinler, Andrew Rybchenko,
	Yong Wang
  Cc: dev

> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Tuesday, April 13, 2021 3:34 PM
> 
> External Email
> 
> ----------------------------------------------------------------------
> On 3/26/2021 4:46 PM, Ferruh Yigit wrote:
> > These headers are used but not included explicitly, including them.
> >
> > "arpa/inet.h" is included for 'htons' and friends.
> > "netinet/in.h" is included for 'IPPROTO_IP'.
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Any comment/review?

Acked-by: Rasesh Mody <rmody@marvell.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] drivers: add missing headers
  2021-04-13 10:31 ` [dpdk-dev] " Andrew Rybchenko
@ 2021-04-14  9:23   ` Ferruh Yigit
  0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2021-04-14  9:23 UTC (permalink / raw)
  To: Andrew Rybchenko, Gagandeep Singh, Hemant Agrawal, Jerin Jacob,
	Rasesh Mody, Shahed Shaikh, Jeff Guo, Haiyue Wang,
	Stephen Hemminger, Long Li, Martin Spinler, Yong Wang
  Cc: dev

On 4/13/2021 11:31 AM, Andrew Rybchenko wrote:
> On 3/26/21 7:46 PM, Ferruh Yigit wrote:
>> These headers are used but not included explicitly, including them.
>>
>> "arpa/inet.h" is included for 'htons' and friends.
>> "netinet/in.h" is included for 'IPPROTO_IP'.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> 

Applied to dpdk-next-net/main, thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-04-14  9:24 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-26 16:46 [dpdk-dev] [PATCH] drivers: add missing headers Ferruh Yigit
2021-04-13 10:04 ` Ferruh Yigit
2021-04-13 13:45   ` [dpdk-dev] [EXT] " Rasesh Mody
2021-04-13 10:31 ` [dpdk-dev] " Andrew Rybchenko
2021-04-14  9:23   ` Ferruh Yigit
2021-04-13 13:15 ` Hemant Agrawal

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git