From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4BDBA0A02; Fri, 26 Mar 2021 21:52:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3029F140E01; Fri, 26 Mar 2021 21:52:19 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 37D6040685 for ; Fri, 26 Mar 2021 21:52:17 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 599BA20B5680; Fri, 26 Mar 2021 13:52:16 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 599BA20B5680 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1616791936; bh=Qmv53eb73E+DAME4W4mZDsaDixjk+5GKPrfJNXP23TI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hl9WHTQMQtexWA521g7MESplZVwXxWQ5jFNXc9Aup2SRBRQJd8oC6Eixq69Qb3cQP V345/twDlPIPpWBDAsjTSKTaXxU55HzDSpUxbXBJJ4dttgDXJ29hP1jU69v0LHOamF 9/vCfH/12EhsopTFbvQ/0QX4CQJWFGkO92u46xp4= Date: Fri, 26 Mar 2021 13:52:16 -0700 From: Tyler Retzlaff To: Ferruh Yigit Cc: Thomas Monjalon , dev@dpdk.org, andrew.rybchenko@oktetlabs.ru, bruce.richardson@intel.com, Shepard Siegel , David Marchand Message-ID: <20210326205216.GA4066@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1615490833-23052-1-git-send-email-roretzla@linux.microsoft.com> <20210324043238.GA31805@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <7e48bf43-5bee-045e-aef2-f56dc72d8736@intel.com> <5945384.p3lA8Brad8@thomas> <20210324162441.GA14991@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [PATCH v2] ethdev: introduce enable_driver_sdk to install driver headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Mar 26, 2021 at 12:02:55PM +0000, Ferruh Yigit wrote: > On 3/24/2021 4:24 PM, Tyler Retzlaff wrote: > >On Wed, Mar 24, 2021 at 12:30:36PM +0100, Thomas Monjalon wrote: > >>24/03/2021 12:27, Ferruh Yigit: > >>> > >>>But not sure how to manage the same problem for whole project, if install all > >>>headers in one patch, or add them gradually via separate patches by time ... > >> > >>We did a cleanup in ethdev but not in other driver classes. > >>When the cleanup will be done gradually, the headers > >>must move in this new category driver_sdk_headers. > > > >yes, some headers are not installed now. so they need only to have > >their api marked __rte_internal and installed (since there should be no > >external consumer as a function of not being installed) > > > >the more difficult case is where headers were installed but the api were > >not marked __rte_internal and appear in the stable version.map. for > >those i guess deprecation notice has to be issued before marking as > >internal. > > > > Are you referring to any specific APIs, can you share list of them? i can't remember the whole list but Thomas originally indicated the following candidate list. baseband/ -> librte_bbdev/rte_bbdev_pmd.h bus/ -> rte_bus.h common/ -> no interface crypto/ -> librte_cryptodev/rte_cryptodev_pmd.h event/ -> librte_eventdev/ mempool/ -> librte_mempool/ net/ -> librte_ethdev/ raw/ -> librte_rawdev/rte_rawdev_pmd.h regex/ -> librte_regexdev/rte_regexdev_driver.h vdpa/ -> librte_vhost/rte_vdpa_dev.h some of these headers are not published, some are.