From: Bruce Richardson <bruce.richardson@intel.com>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4] build: add platform meson option
Date: Wed, 31 Mar 2021 13:39:27 +0100 [thread overview]
Message-ID: <20210331123927.GB249@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <09b4324c8bd845e8a8ee221f10afb816@pantheon.tech>
On Wed, Mar 31, 2021 at 12:16:59PM +0000, Juraj Linkeš wrote:
> Bruce, what do you think of the patch now? Do we need to add/change anything else, like documentation?
>
> One thing to note is that we're changing the default behavior in this patch from machine=native to machine=generic (or more accurately, to cpu_instruction_set=generic). Do we want to do that?
>
The patch in general looks ok, but I am uncertain about this change indeed.
Especially since the -march flag we mirror to the pkg-config file. I'd like
to see something like [1] included along with such a change. It allows us
per-arch to select the flags to send to the pkg-config file, rather than
just always using machine_args blindly.
Feedback appreciated.
/Bruce
[1] http://patches.dpdk.org/project/dpdk/patch/20201211155111.145279-1-bruce.richardson@intel.com/
next prev parent reply other threads:[~2021-03-31 12:39 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 15:47 [dpdk-dev] [RFC PATCH v1] " Juraj Linkeš
2020-11-26 16:02 ` Bruce Richardson
2020-11-27 8:31 ` Juraj Linkeš
2020-11-27 14:07 ` Bruce Richardson
2020-12-23 11:23 ` Juraj Linkeš
2021-01-04 11:52 ` [dpdk-dev] [RFC PATCH v2] " Juraj Linkeš
2021-01-04 11:59 ` Juraj Linkeš
2021-01-05 22:17 ` David Christensen
2021-01-06 14:42 ` Bruce Richardson
2021-02-19 9:11 ` Juraj Linkeš
2021-02-22 21:25 ` David Christensen
2021-02-23 8:45 ` Juraj Linkeš
2021-02-23 9:43 ` Bruce Richardson
2021-02-25 12:51 ` Juraj Linkeš
2021-02-25 12:54 ` Bruce Richardson
2021-02-25 12:57 ` Juraj Linkeš
2021-03-29 11:03 ` [dpdk-dev] [PATCH v3] " Juraj Linkeš
2021-03-29 12:50 ` [dpdk-dev] [PATCH v4] " Juraj Linkeš
2021-03-31 12:16 ` Juraj Linkeš
2021-03-31 12:19 ` Juraj Linkeš
2021-03-31 12:39 ` Bruce Richardson [this message]
2021-04-15 13:32 ` Juraj Linkeš
2021-04-15 13:51 ` Bruce Richardson
2021-04-20 8:08 ` [dpdk-dev] [PATCH v5] build: use platform option for generic and native Juraj Linkeš
2021-04-20 8:16 ` Juraj Linkeš
2021-04-20 8:36 ` Thomas Monjalon
2021-04-21 8:37 ` Juraj Linkeš
2021-04-22 8:34 ` Wang, Yinan
2021-06-30 13:09 ` [dpdk-dev] [PATCH v6] build: use platform for generic and native builds Juraj Linkeš
2021-07-06 9:44 ` [dpdk-dev] [PATCH v7] " Juraj Linkeš
2021-07-07 13:59 ` Bruce Richardson
2021-07-09 12:30 ` Thomas Monjalon
2021-07-09 13:55 ` Juraj Linkeš
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210331123927.GB249@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=juraj.linkes@pantheon.tech \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).