From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id DC7D4A034F;
	Wed, 31 Mar 2021 14:39:35 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 64682140ECF;
	Wed, 31 Mar 2021 14:39:35 +0200 (CEST)
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by mails.dpdk.org (Postfix) with ESMTP id B5E96406A3
 for <dev@dpdk.org>; Wed, 31 Mar 2021 14:39:33 +0200 (CEST)
IronPort-SDR: tTmq2lSMHC2lZmwSL3CuYqK0hWvGn4hxyA9Rcndo7A8HgmWjFt8mUXhWnz2XNiFaETP5tvudLT
 DRIE+DgjJnnw==
X-IronPort-AV: E=McAfee;i="6000,8403,9939"; a="277175581"
X-IronPort-AV: E=Sophos;i="5.81,293,1610438400"; d="scan'208";a="277175581"
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 31 Mar 2021 05:39:32 -0700
IronPort-SDR: 6cqbBogLNivg8rfApVv6rzjSPUNQimV8LsWkrCacbq+FFQS+knpHN/eIX3jJWWX/1DbGadwg1N
 /l2nKVZCJrLg==
X-IronPort-AV: E=Sophos;i="5.81,293,1610438400"; d="scan'208";a="516878843"
Received: from bricha3-mobl.ger.corp.intel.com ([10.252.29.162])
 by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;
 31 Mar 2021 05:39:31 -0700
Date: Wed, 31 Mar 2021 13:39:27 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Juraj =?utf-8?Q?Linke=C5=A1?= <juraj.linkes@pantheon.tech>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
 "david.marchand@redhat.com" <david.marchand@redhat.com>,
 "Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Message-ID: <20210331123927.GB249@bricha3-MOBL.ger.corp.intel.com>
References: <1617015818-13240-1-git-send-email-juraj.linkes@pantheon.tech>
 <1617022234-13618-1-git-send-email-juraj.linkes@pantheon.tech>
 <09b4324c8bd845e8a8ee221f10afb816@pantheon.tech>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <09b4324c8bd845e8a8ee221f10afb816@pantheon.tech>
Subject: Re: [dpdk-dev] [PATCH v4] build: add platform meson option
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Mar 31, 2021 at 12:16:59PM +0000, Juraj Linkeš wrote:
> Bruce, what do you think of the patch now? Do we need to add/change anything else, like documentation?
> 
> One thing to note is that we're changing the default behavior in this patch from machine=native to machine=generic (or more accurately, to cpu_instruction_set=generic). Do we want to do that?
> 
The patch in general looks ok, but I am uncertain about this change indeed.
Especially since the -march flag we mirror to the pkg-config file. I'd like
to see something like [1] included along with such a change. It allows us
per-arch to select the flags to send to the pkg-config file, rather than
just always using machine_args blindly.

Feedback appreciated.

/Bruce

[1] http://patches.dpdk.org/project/dpdk/patch/20201211155111.145279-1-bruce.richardson@intel.com/