From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 011A6A034F; Thu, 1 Apr 2021 04:37:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7A7BF140FA7; Thu, 1 Apr 2021 04:37:21 +0200 (CEST) Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by mails.dpdk.org (Postfix) with ESMTP id 0DFCE40142 for ; Thu, 1 Apr 2021 04:37:19 +0200 (CEST) Received: by mail-pg1-f181.google.com with SMTP id v186so615080pgv.7 for ; Wed, 31 Mar 2021 19:37:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=r6Zgyke12mv/7dOsjrKdnViMEGcFKiaJkdUY4FO5ZLU=; b=IInX1z5l7cK+xABlbdig4gHk2c0uynBQH53UrfSmazdJsMAGwzDXP+5fiHhThq2UAS YjxldlakA26j6r/RjviE7hPooVGLRu5RZQuvPJ/3UP968XK7e+jL0tSJX6pQZWJ7bSeq KK2pjYAkLW9pivbq7tjpnbMDkafZhRl0xE/zFYyjBazR5mS7DNFWpZ/oRjlqaxU/1FLc DaAtpmSCkQ2xflSS+fGhWgSqF25kbP17GLdCv2wSvpRIglPfdRydtAw3QUhx3WS9kgo9 seiKaJI5GFeqpOG22HbNXSGboRt2AY+cvE9p7af+LMFgUvwnyQLntyXQys9alOwu60bF AoUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=r6Zgyke12mv/7dOsjrKdnViMEGcFKiaJkdUY4FO5ZLU=; b=SHj0UrvJH+ZYECQsfTUUQI+84ruTttRtkJPoxGeF3IHJa8BcOiur26fHpHNtcNzRcD MIiSxDuH+baNw9DpzyfRVWLFPWnFfLgo3EGl7PA/5n5vG123Wl7SspUnIqV6ahLQuM/u 61fYKaEnnZrdRonmgoBFhas0CJMJ1ErQU6HbfkOXRkDo+d+StWCDXkah5uEtuYEOuio+ XAWS0Zz5DJEvx3lBWxId8LrIvjCgyauaz0v2fgdBs89Uhc96TApMKqQTWur/rtUgHa0v JSY3L/8h005mxyDNDTCfAGZx7FiZBl/sM8Bs2FKw9LUOSoH8bsZv53sTIykgZbmD93hz 3MdA== X-Gm-Message-State: AOAM531tZvP7UI6rjy0dHLb/zjG2NeJvkUBizZb58t75y03NiqSLWH84 hob3GK7a7QKTOfoosk/iN2A4xQ== X-Google-Smtp-Source: ABdhPJxhaXgGZNfpn/luZkqUn1lrG6gR7eoGkKboVZY5gWuRokg74IMgFoWe6ni4c2ftYQuLVhlyJQ== X-Received: by 2002:a63:ed49:: with SMTP id m9mr130325pgk.323.1617244639050; Wed, 31 Mar 2021 19:37:19 -0700 (PDT) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id k63sm3582723pfd.48.2021.03.31.19.37.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Mar 2021 19:37:18 -0700 (PDT) Date: Wed, 31 Mar 2021 19:37:10 -0700 From: Stephen Hemminger To: Wenwu Ma Cc: qiming.yang@intel.com, qi.z.zhang@intel.com, dev@dpdk.org Message-ID: <20210331193710.75ae3880@hermes.local> In-Reply-To: <20210401132453.17786-1-wenwux.ma@intel.com> References: <20210401132453.17786-1-wenwux.ma@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/ice: fix illegal pointer access in dev init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 1 Apr 2021 13:24:53 +0000 Wenwu Ma wrote: > + dev->data->mac_addrs = rte_zmalloc(NULL, > + sizeof(struct rte_ether_addr) * ICE_NUM_MACADDR_MAX, 0); This looks like a good place to use rte_calloc().