DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/igc: fix Rx error counter for badlen packets
@ 2021-04-01  1:16 Alvin Zhang
  0 siblings, 0 replies; 3+ messages in thread
From: Alvin Zhang @ 2021-04-01  1:16 UTC (permalink / raw)
  To: haiyue.wang, jia.guo; +Cc: dev

When the size of the packet is less than the minimum or greater
than the maximum, the packet will be counted twice in the error
packet counter.

Fixes: e6defdfddc3b ("net/igc: enable statistics")
Cc: stable@dpdk.org

Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
---
 drivers/net/igc/igc_ethdev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c
index 0ea6e2a..c398701 100644
--- a/drivers/net/igc/igc_ethdev.c
+++ b/drivers/net/igc/igc_ethdev.c
@@ -1901,8 +1901,7 @@ static int eth_igc_vlan_tpid_set(struct rte_eth_dev *dev,
 
 	/* Rx Errors */
 	rte_stats->imissed = stats->mpc;
-	rte_stats->ierrors = stats->crcerrs +
-			stats->rlec + stats->ruc + stats->roc +
+	rte_stats->ierrors = stats->crcerrs + stats->rlec +
 			stats->rxerrc + stats->algnerrc;
 
 	/* Tx Errors */
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/igc: fix Rx error counter for badlen packets
  2021-04-01  1:16 Alvin Zhang
@ 2021-04-01  1:57 ` Wang, Haiyue
  0 siblings, 0 replies; 3+ messages in thread
From: Wang, Haiyue @ 2021-04-01  1:57 UTC (permalink / raw)
  To: Zhang, AlvinX, Guo, Jia; +Cc: dev, stable

> -----Original Message-----
> From: Zhang, AlvinX <alvinx.zhang@intel.com>
> Sent: Thursday, April 1, 2021 09:17
> To: Wang, Haiyue <haiyue.wang@intel.com>; Guo, Jia <jia.guo@intel.com>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/igc: fix Rx error counter for badlen packets
> 
> When the size of the packet is less than the minimum or greater
> than the maximum, the packet will be counted twice in the error
> packet counter.

This message is not clear, the packet should be minimum or greater,
but not at the same time, why twice ? Please describe the new stats
you use more clear.

> 
> Fixes: e6defdfddc3b ("net/igc: enable statistics")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> ---
>  drivers/net/igc/igc_ethdev.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c
> index 0ea6e2a..c398701 100644
> --- a/drivers/net/igc/igc_ethdev.c
> +++ b/drivers/net/igc/igc_ethdev.c
> @@ -1901,8 +1901,7 @@ static int eth_igc_vlan_tpid_set(struct rte_eth_dev *dev,
> 
>  	/* Rx Errors */
>  	rte_stats->imissed = stats->mpc;
> -	rte_stats->ierrors = stats->crcerrs +
> -			stats->rlec + stats->ruc + stats->roc +
> +	rte_stats->ierrors = stats->crcerrs + stats->rlec +
>  			stats->rxerrc + stats->algnerrc;
> 
>  	/* Tx Errors */
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dpdk-dev] [PATCH] net/igc: fix Rx error counter for badlen packets
@ 2021-04-01  1:16 Alvin Zhang
  2021-04-01  1:57 ` Wang, Haiyue
  0 siblings, 1 reply; 3+ messages in thread
From: Alvin Zhang @ 2021-04-01  1:16 UTC (permalink / raw)
  To: haiyue.wang, jia.guo; +Cc: dev, Alvin Zhang, stable

When the size of the packet is less than the minimum or greater
than the maximum, the packet will be counted twice in the error
packet counter.

Fixes: e6defdfddc3b ("net/igc: enable statistics")
Cc: stable@dpdk.org

Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
---
 drivers/net/igc/igc_ethdev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c
index 0ea6e2a..c398701 100644
--- a/drivers/net/igc/igc_ethdev.c
+++ b/drivers/net/igc/igc_ethdev.c
@@ -1901,8 +1901,7 @@ static int eth_igc_vlan_tpid_set(struct rte_eth_dev *dev,
 
 	/* Rx Errors */
 	rte_stats->imissed = stats->mpc;
-	rte_stats->ierrors = stats->crcerrs +
-			stats->rlec + stats->ruc + stats->roc +
+	rte_stats->ierrors = stats->crcerrs + stats->rlec +
 			stats->rxerrc + stats->algnerrc;
 
 	/* Tx Errors */
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-04-01  1:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-01  1:16 [dpdk-dev] [PATCH] net/igc: fix Rx error counter for badlen packets Alvin Zhang
2021-04-01  1:16 Alvin Zhang
2021-04-01  1:57 ` Wang, Haiyue

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git