From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCA7DA034F; Thu, 1 Apr 2021 07:21:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CFF0E40142; Thu, 1 Apr 2021 07:21:40 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 9816F4013F; Thu, 1 Apr 2021 07:21:39 +0200 (CEST) IronPort-SDR: zBIaE/DfRhyvJ16srNKFJdJwotJJLmwPhfTwn4VjNQ36zzfH/C8MSnDqu6jF4ZPEspDFIGPxz9 5XbwVpE4s7Jw== X-IronPort-AV: E=McAfee;i="6000,8403,9940"; a="172187781" X-IronPort-AV: E=Sophos;i="5.81,295,1610438400"; d="scan'208";a="172187781" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2021 22:21:38 -0700 IronPort-SDR: Q8HYHtaW7TVwZjziGCdwkVhExIepkKBfrBQM3xyaRXTtHckgt4WpP5LB2SeAwvOCtzjWijlZ1G wpzS3H61GUZg== X-IronPort-AV: E=Sophos;i="5.81,295,1610438400"; d="scan'208";a="446069541" Received: from shwdenpg235.ccr.corp.intel.com ([10.240.182.60]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2021 22:21:36 -0700 From: Alvin Zhang To: haiyue.wang@intel.com, jia.guo@intel.com Cc: dev@dpdk.org, Alvin Zhang , stable@dpdk.org Date: Thu, 1 Apr 2021 13:21:32 +0800 Message-Id: <20210401052132.21080-1-alvinx.zhang@intel.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20210401050821.13640-1-alvinx.zhang@intel.com> References: <20210401050821.13640-1-alvinx.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2] net/e1000: fix Rx error counter for badlen packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When the size of a packet in Rx channel is less than the minimum or greater than the maximum, the packet will be simultaneously counted by RLEC(Receive Length Error Count) and RUC(Receive Under Size Count)/ROC(Receive Oversize Count) registers. This patch fixes the issue of counting a length error packet twice when counting the total number of received error packets. Fixes: 70bdb18657da ("ethdev: add Rx error counters for missed, badcrc and badlen packets") Cc: stable@dpdk.org Signed-off-by: Alvin Zhang --- V2: Refine commit log --- drivers/net/e1000/em_ethdev.c | 3 +-- drivers/net/e1000/igb_ethdev.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c index 3c6f643..4d96d96 100644 --- a/drivers/net/e1000/em_ethdev.c +++ b/drivers/net/e1000/em_ethdev.c @@ -975,8 +975,7 @@ static int eth_em_pci_remove(struct rte_pci_device *pci_dev) /* Rx Errors */ rte_stats->imissed = stats->mpc; - rte_stats->ierrors = stats->crcerrs + - stats->rlec + stats->ruc + stats->roc + + rte_stats->ierrors = stats->crcerrs + stats->rlec + stats->rxerrc + stats->algnerrc + stats->cexterr; /* Tx Errors */ diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c index 1716d6b..2927cd7 100644 --- a/drivers/net/e1000/igb_ethdev.c +++ b/drivers/net/e1000/igb_ethdev.c @@ -1827,8 +1827,7 @@ static int eth_igbvf_pci_remove(struct rte_pci_device *pci_dev) /* Rx Errors */ rte_stats->imissed = stats->mpc; - rte_stats->ierrors = stats->crcerrs + - stats->rlec + stats->ruc + stats->roc + + rte_stats->ierrors = stats->crcerrs + stats->rlec + stats->rxerrc + stats->algnerrc + stats->cexterr; /* Tx Errors */ -- 1.8.3.1