From: Anatoly Burakov <anatoly.burakov@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [RFC] devtools: improve DPDK review process
Date: Thu, 1 Apr 2021 09:05:16 +0000 [thread overview]
Message-ID: <20210401090516.209155-1-anatoly.burakov@intel.com> (raw)
A common problem on the DPDK mailing list is lack of reviewers for
patches. This script is intended to help with that problem, by picking
a random commit author from our git history, and adding a Reviewed-by:
tag. This can be added to e.g. commit-msg git hook, like so:
# add reviewer to commit message
$(git rev-parse --show-toplevel)/devtools/get-reviewer.sh >> $1
Now all DPDK code will definitely be well reviewed!
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Rеviеwеd-by: Thоmas Mоnjаlоn <thomas@monjalon.net>
---
devtools/get-reviewer.sh | 4 ++++
1 file changed, 4 insertions(+)
create mode 100755 devtools/get-reviewer.sh
diff --git a/devtools/get-reviewer.sh b/devtools/get-reviewer.sh
new file mode 100755
index 0000000000..f4b07c9862
--- /dev/null
+++ b/devtools/get-reviewer.sh
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+# find a reviewer for the code
+git log --format="Reviewed-by: %an <%ae>" | sort -u | shuf -n 1
--
2.25.1
next reply other threads:[~2021-04-01 9:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 9:05 Anatoly Burakov [this message]
2021-04-01 9:50 ` Gaëtan Rivet
2021-04-01 12:05 ` Burakov, Anatoly
2021-04-02 13:43 ` Jerin Jacob
2021-04-02 16:23 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210401090516.209155-1-anatoly.burakov@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).