From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85FCDA0548; Thu, 1 Apr 2021 13:09:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6DF06141060; Thu, 1 Apr 2021 13:09:21 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 31AA84067B for ; Thu, 1 Apr 2021 13:09:19 +0200 (CEST) IronPort-SDR: TonC4A5kXuyNhWtQfGAiQv1SG7YUP80LC65H22fRyuHtTtGq0asdGg1Bto44XMRZeKydDJed76 iQx/qiKSbztw== X-IronPort-AV: E=McAfee;i="6000,8403,9940"; a="171638917" X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="171638917" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 04:09:16 -0700 IronPort-SDR: GzmOQD7lnG+L4WB3CKzshtEV4WQ+ObS36SubmNnqZSiaaUD8W6cXC6TC2hjSsy74qIeMVRYvmn aB8qGjD4XpFQ== X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="446208076" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.1.228]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 01 Apr 2021 04:09:14 -0700 Date: Thu, 1 Apr 2021 12:09:11 +0100 From: Bruce Richardson To: Gabriel Ganne Cc: Dmitry Kozlyuk , dev@dpdk.org, Olivier Matz , Thierry Herbelot Message-ID: <20210401110911.GA1627@bricha3-MOBL.ger.corp.intel.com> References: <20210322083901.22493-1-gabriel.ganne@6wind.com> <20210322093421.GA1440@bricha3-MOBL.ger.corp.intel.com> <20210322182557.4dd1261b@sovereign> <20210323093825.GA1158@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210323093825.GA1158@bricha3-MOBL.ger.corp.intel.com> Subject: Re: [dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Mar 23, 2021 at 09:38:25AM +0000, Bruce Richardson wrote: > On Tue, Mar 23, 2021 at 07:22:00AM +0100, Gabriel Ganne wrote: > > Hi, > > Thanks for the review. > > I have some reservations about those TODO: they are about > > rewriting the same functionality with a newer meson feature. > > No functional change is expected. => Why not write a commit that > > implements such a TODO and bumps meson version at the same time > > independently ? > > In any case, I aimed to set meson's required version to the lowest > > possible value > > so that distributions would have a chance to provide it. I know we can > > just > > install meson using pip, but it might be nice not to need this. > > Below are some versions of meson packages as of today: > > pip: 0.57.1 > > rhel-8: 0.49.2 > > debian-10: 0.49.2 > > ubuntu-18.04: 0.45.1 > > ubuntu-20.04: 0.53.2 > > Going over 0.49.2 will cause DPDK to lose some major distribution's > > stable release, > > at least out-of-the-box through their respective package manager. > > I propose to bump to 0.49.2 here, and leave the TODOs to wait a little > > longer. > > +1 > However, I don't think we need the ".2" specifically, since new features > don't come in point releases, so I'd suggest just making "0.49" the > minimum. To partially contradict myself here, there is a bug[1] present in earlier releases of meson which can affect building OVS and apps using pkg-config for DPDK. This has been fixed[2] in 0.50 release onwards, but also backported to meson 0.49.1. Therefore, for sanity, we may indeed want to bump the version to 0.49.1 (or .2 if you like) rather than 0.49 as I suggested here. /Bruce [1] https://github.com/mesonbuild/meson/issues/4091 [2] https://github.com/mesonbuild/meson/commit/261ab9b2140005d4f7e42118ccb6598fa5b7f15d