From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id EC756A0548;
Thu, 1 Apr 2021 13:51:09 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id B47A61410EC;
Thu, 1 Apr 2021 13:50:34 +0200 (CEST)
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
by mails.dpdk.org (Postfix) with ESMTP id C14B71410B9
for <dev@dpdk.org>; Thu, 1 Apr 2021 13:50:32 +0200 (CEST)
IronPort-SDR: bTnUYpxtlY2USr21zUG++w1o3LqToaI3JR3XvFarZiyd4glwLPdtPNA4N2pcOidX9EKTzyKNU2
siwUbMPcEUQg==
X-IronPort-AV: E=McAfee;i="6000,8403,9940"; a="179760784"
X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="179760784"
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
01 Apr 2021 04:50:32 -0700
IronPort-SDR: WiA/exCAyn2RdngsL0uyy8AuENHdnJQOAt5cWRT9JtrXjkcKEOwhtQEMs34gR9L0z6tOsDiVQw
6oe6WTCODHnw==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="446062650"
Received: from silpixa00399126.ir.intel.com ([10.237.223.116])
by FMSMGA003.fm.intel.com with ESMTP; 01 Apr 2021 04:50:30 -0700
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, david.marchand@redhat.com, bluca@debian.org,
Bruce Richardson <bruce.richardson@intel.com>
Date: Thu, 1 Apr 2021 12:50:01 +0100
Message-Id: <20210401115009.1063844-7-bruce.richardson@intel.com>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20210401115009.1063844-1-bruce.richardson@intel.com>
References: <20210401115009.1063844-1-bruce.richardson@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [RFC PATCH 06/14] build: reduce indentation in app build
spec
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
As with the lib and drivers directories, we can use "continue" keyword to
reduce the indentation level of the majority of the foreach block. At the
same time, we can also replace tab indentation with spaces.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
app/meson.build | 100 ++++++++++++++++++++++++------------------------
1 file changed, 50 insertions(+), 50 deletions(-)
diff --git a/app/meson.build b/app/meson.build
index 50a53dbde8..dcffda9d90 100644
--- a/app/meson.build
+++ b/app/meson.build
@@ -2,71 +2,71 @@
# Copyright(c) 2017-2019 Intel Corporation
if is_windows
- subdir_done()
+ subdir_done()
endif
apps = [
- 'pdump',
- 'proc-info',
- 'test-acl',
- 'test-bbdev',
- 'test-cmdline',
- 'test-compress-perf',
- 'test-crypto-perf',
- 'test-eventdev',
- 'test-fib',
- 'test-flow-perf',
- 'test-pipeline',
- 'test-pmd',
- 'test-regex',
- 'test-sad']
+ 'pdump',
+ 'proc-info',
+ 'test-acl',
+ 'test-bbdev',
+ 'test-cmdline',
+ 'test-compress-perf',
+ 'test-crypto-perf',
+ 'test-eventdev',
+ 'test-fib',
+ 'test-flow-perf',
+ 'test-pipeline',
+ 'test-pmd',
+ 'test-regex',
+ 'test-sad']
default_cflags = machine_args + ['-DALLOW_EXPERIMENTAL_API']
default_ldflags = []
if get_option('default_library') == 'static' and not is_windows
- default_ldflags += ['-Wl,--export-dynamic']
+ default_ldflags += ['-Wl,--export-dynamic']
endif
foreach app:apps
- build = true
- name = app
- sources = []
- includes = []
- cflags = default_cflags
- ldflags = default_ldflags
- objs = [] # other object files to link against, used e.g. for
- # instruction-set optimized versions of code
+ build = true
+ name = app
+ sources = []
+ includes = []
+ cflags = default_cflags
+ ldflags = default_ldflags
+ objs = [] # other object files to link against, used e.g. for
+ # instruction-set optimized versions of code
- # use "deps" for internal DPDK dependencies, and "ext_deps" for
- # external package/library requirements
- ext_deps = []
- deps = []
+ # use "deps" for internal DPDK dependencies, and "ext_deps" for
+ # external package/library requirements
+ ext_deps = []
+ deps = []
- subdir(name)
+ subdir(name)
- if build
- dep_objs = []
- foreach d:deps
- dep_objs += get_variable(get_option('default_library')
- + '_rte_' + d)
- endforeach
+ if not build
+ continue
+ endif
- link_libs = []
- if get_option('default_library') == 'static'
- link_libs = dpdk_static_libraries + dpdk_drivers
- endif
+ dep_objs = []
+ foreach d:deps
+ dep_objs += get_variable(get_option('default_library') + '_rte_' + d)
+ endforeach
- executable('dpdk-' + name,
- sources,
- c_args: cflags,
- link_args: ldflags,
- link_whole: link_libs,
- dependencies: dep_objs,
- include_directories: includes,
- install_rpath: join_paths(get_option('prefix'),
- driver_install_path),
- install: true)
- endif
+ link_libs = []
+ if get_option('default_library') == 'static'
+ link_libs = dpdk_static_libraries + dpdk_drivers
+ endif
+
+ executable('dpdk-' + name,
+ sources,
+ c_args: cflags,
+ link_args: ldflags,
+ link_whole: link_libs,
+ dependencies: dep_objs,
+ include_directories: includes,
+ install_rpath: join_paths(get_option('prefix'), driver_install_path),
+ install: true)
endforeach
# special case the autotests
--
2.27.0