From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04250A0548; Thu, 1 Apr 2021 14:33:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D844C141176; Thu, 1 Apr 2021 14:33:47 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 28DF0141176 for ; Thu, 1 Apr 2021 14:33:45 +0200 (CEST) IronPort-SDR: 2QsU+cQYrLtaxd8FllgXA7HQPAt2oqcOuRL3YzyBkAQIeDKQidvwnnwU3ryRDD6tERW88WHwC4 34mC12oy4gCA== X-IronPort-AV: E=McAfee;i="6000,8403,9940"; a="172265020" X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="172265020" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 05:33:45 -0700 IronPort-SDR: j+iZn2ayZ3cRsEL9yn47x2x0y3VUgtbe34dr5E5wHt4ei950f6iwAA/ufR+MWWKAQnEnyMsLKW 9TTxuAYnD0WQ== X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="455966449" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.1.228]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 01 Apr 2021 05:33:43 -0700 Date: Thu, 1 Apr 2021 13:33:39 +0100 From: Bruce Richardson To: Andrew Rybchenko Cc: dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com, bluca@debian.org Message-ID: <20210401123339.GB1627@bricha3-MOBL.ger.corp.intel.com> References: <20210401115009.1063844-1-bruce.richardson@intel.com> <20210401115009.1063844-6-bruce.richardson@intel.com> <9911ffc6-e1d4-3411-896a-4cdcf452c1a2@oktetlabs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9911ffc6-e1d4-3411-896a-4cdcf452c1a2@oktetlabs.ru> Subject: Re: [dpdk-dev] [RFC PATCH 05/14] build: clean up driver list indentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 01, 2021 at 03:14:40PM +0300, Andrew Rybchenko wrote: > On 4/1/21 2:50 PM, Bruce Richardson wrote: > > Ensure all lists of drivers are one-per-line and replace tabs with spaces > > in each file to correspond to the new standard. > > > > Signed-off-by: Bruce Richardson > > --- > > drivers/baseband/meson.build | 8 ++- > > drivers/bus/meson.build | 7 ++- > > drivers/common/meson.build | 9 +++- > > drivers/compress/meson.build | 7 ++- > > drivers/crypto/meson.build | 38 ++++++------- > > drivers/event/meson.build | 17 ++++-- > > drivers/mempool/meson.build | 8 ++- > > drivers/meson.build | 33 ++++++------ > > drivers/net/meson.build | 102 +++++++++++++++++------------------ > > drivers/raw/meson.build | 15 +++--- > > drivers/regex/meson.build | 3 +- > > drivers/vdpa/meson.build | 4 +- > > 12 files changed, 142 insertions(+), 109 deletions(-) > > > > diff --git a/drivers/baseband/meson.build b/drivers/baseband/meson.build > > index 920e3b02ee..22d0036cd7 100644 > > --- a/drivers/baseband/meson.build > > +++ b/drivers/baseband/meson.build > > @@ -2,7 +2,11 @@ > > # Copyright(c) 2018 Luca Boccassi > > > > if is_windows > > - subdir_done() > > + subdir_done() > > endif > > > > -drivers = ['null', 'turbo_sw', 'fpga_lte_fec', 'fpga_5gnr_fec', 'acc100'] > > +drivers = ['null', > > + 'turbo_sw', > > + 'fpga_lte_fec', > > + 'fpga_5gnr_fec', > > + 'acc100'] > > It looks like it is more than 4 spaces here (and many similar > cases below), but previous patch and longs lists below in the > file use 4 spaces alignment. Yes, for indenting line continuations, I've tended to prefer to use a double-indent, and save single indent for new blocks of code.