From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 946CBA0548; Thu, 1 Apr 2021 16:05:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1A09F14131C; Thu, 1 Apr 2021 16:05:57 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 6F41C1412BA for ; Thu, 1 Apr 2021 16:05:54 +0200 (CEST) IronPort-SDR: kpUJsaF4D9Yu5fox6c57fjbXFgufWyb0YsZ0kFIJMx4IsRLRRIHe3Ry7s6ahjkZm59H24vXE0t ZTeX9vrtEEoQ== X-IronPort-AV: E=McAfee;i="6000,8403,9941"; a="253587289" X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="253587289" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 07:05:53 -0700 IronPort-SDR: hOP6CLV+Z+WtUF+VXH3TmFpM8R5SGzjH3SFp5zsdfpIH/pF0E1f22BpMBpyEXd925smiKAd72X 7kmhruqQJfQw== X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="377713947" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.1.228]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 01 Apr 2021 07:05:52 -0700 Date: Thu, 1 Apr 2021 15:05:48 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, david.marchand@redhat.com, bluca@debian.org Message-ID: <20210401140548.GD1627@bricha3-MOBL.ger.corp.intel.com> References: <20210401115009.1063844-1-bruce.richardson@intel.com> <20210401115009.1063844-7-bruce.richardson@intel.com> <19523480.V5uBPq5WPB@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19523480.V5uBPq5WPB@thomas> Subject: Re: [dpdk-dev] [RFC PATCH 06/14] build: reduce indentation in app build spec X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 01, 2021 at 03:32:14PM +0200, Thomas Monjalon wrote: > 01/04/2021 13:50, Bruce Richardson: > > As with the lib and drivers directories, we can use "continue" keyword to > > reduce the indentation level of the majority of the foreach block. At the > > same time, we can also replace tab indentation with spaces. > > > > Signed-off-by: Bruce Richardson > > --- > > + 'pdump', > > + 'proc-info', > > + 'test-acl', > > + 'test-bbdev', > > + 'test-cmdline', > > + 'test-compress-perf', > > + 'test-crypto-perf', > > + 'test-eventdev', > > + 'test-fib', > > + 'test-flow-perf', > > + 'test-pipeline', > > + 'test-pmd', > > + 'test-regex', > > + 'test-sad'] > > Can we have an extra comma like this? > > 'test-sad', > ] > Not sure about changes of that magnitude. :-) Will try and standardize on that on all lists for a V2.