From: Pallavi Kadam <pallavi.kadam@intel.com>
To: dev@dpdk.org, thomas@monjalon.net
Cc: dmitry.kozliuk@gmail.com, ranjit.menon@intel.com,
qiming.yang@intel.com, qi.z.zhang@intel.com,
ferruh.yigit@intel.com, pallavi.kadam@intel.com
Subject: [dpdk-dev] [PATCH v3 3/3] net/ice: disable ice DDP package on Windows
Date: Thu, 1 Apr 2021 18:26:21 -0700 [thread overview]
Message-ID: <20210402012621.7944-4-pallavi.kadam@intel.com> (raw)
In-Reply-To: <20210402012621.7944-1-pallavi.kadam@intel.com>
Disable loading of external DDP package as it is not
supported on Windows.
Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
Acked-by: Jie Zhou <jizh@microsoft.com>
---
doc/guides/nics/ice.rst | 5 +++++
drivers/net/ice/ice_ethdev.c | 6 ++++++
2 files changed, 11 insertions(+)
diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst
index 100086132..8d40d1741 100644
--- a/doc/guides/nics/ice.rst
+++ b/doc/guides/nics/ice.rst
@@ -330,3 +330,8 @@ is stored in ``ice_adapter->active_pkg_type``.
A symbolic link to the DDP package file is also ok. The same package
file is used by both the kernel driver and the DPDK PMD.
+
+ .. Note::
+
+ Windows support: The DDP package is not supported on Windows so,
+ loading of the package is disabled on Windows.
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 81558fd8d..1dea6421c 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -1650,6 +1650,7 @@ ice_pf_setup(struct ice_pf *pf)
* Extract device serial number from PCIe Configuration Space and
* determine the pkg file path according to the DSN.
*/
+#ifndef RTE_EXEC_ENV_WINDOWS
static int
ice_pkg_file_search_path(struct rte_pci_device *pci_dev, char *pkg_file)
{
@@ -1693,6 +1694,7 @@ ice_pkg_file_search_path(struct rte_pci_device *pci_dev, char *pkg_file)
strncpy(pkg_file, ICE_PKG_FILE_DEFAULT, ICE_MAX_PKG_FILENAME_SIZE);
return 0;
}
+#endif
enum ice_pkg_type
ice_load_pkg_type(struct ice_hw *hw)
@@ -1718,6 +1720,7 @@ ice_load_pkg_type(struct ice_hw *hw)
return package_type;
}
+#ifndef RTE_EXEC_ENV_WINDOWS
static int ice_load_pkg(struct rte_eth_dev *dev)
{
struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
@@ -1793,6 +1796,7 @@ static int ice_load_pkg(struct rte_eth_dev *dev)
rte_free(buf);
return err;
}
+#endif
static void
ice_base_queue_get(struct ice_pf *pf)
@@ -2073,6 +2077,7 @@ ice_dev_init(struct rte_eth_dev *dev)
return -EINVAL;
}
+#ifndef RTE_EXEC_ENV_WINDOWS
ret = ice_load_pkg(dev);
if (ret) {
if (ad->devargs.safe_mode_support == 0) {
@@ -2085,6 +2090,7 @@ ice_dev_init(struct rte_eth_dev *dev)
"Entering Safe Mode");
ad->is_safe_mode = 1;
}
+#endif
PMD_INIT_LOG(INFO, "FW %d.%d.%05d API %d.%d",
hw->fw_maj_ver, hw->fw_min_ver, hw->fw_build,
--
2.18.0.windows.1
next prev parent reply other threads:[~2021-04-02 0:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 21:59 [dpdk-dev] [PATCH 0/4] Support ice PMD " Pallavi Kadam
2021-03-03 21:59 ` [dpdk-dev] [PATCH 1/4] build: enable iavf driver " Pallavi Kadam
2021-03-03 21:59 ` [dpdk-dev] [PATCH 2/4] net/ice: build " Pallavi Kadam
2021-03-04 12:56 ` David Marchand
2021-03-08 23:30 ` Kadam, Pallavi
2021-03-03 21:59 ` [dpdk-dev] [PATCH 3/4] net/ice: disable ice DDP package " Pallavi Kadam
2021-03-03 23:12 ` Dmitry Kozlyuk
2021-03-05 0:31 ` Kadam, Pallavi
2021-03-03 21:59 ` [dpdk-dev] [PATCH 4/4] doc: update ice PMD and 21.05 release notes Pallavi Kadam
2021-03-03 23:13 ` Dmitry Kozlyuk
2021-03-05 0:25 ` Kadam, Pallavi
2021-03-11 1:58 ` [dpdk-dev] [PATCH v2 0/3] Support ice PMD on Windows Pallavi Kadam
2021-03-11 1:58 ` [dpdk-dev] [PATCH v2 1/3] build: enable iavf base code to build on windows Pallavi Kadam
2021-03-25 16:41 ` Jie Zhou
2021-03-26 11:41 ` Ferruh Yigit
2021-03-28 2:05 ` Kadam, Pallavi
2021-03-11 1:58 ` [dpdk-dev] [PATCH v2 2/3] net/ice: build on Windows Pallavi Kadam
2021-03-25 16:48 ` Jie Zhou
2021-03-26 11:51 ` Ferruh Yigit
2021-03-28 2:00 ` Kadam, Pallavi
2021-03-26 11:58 ` Ferruh Yigit
2021-03-28 2:04 ` Kadam, Pallavi
2021-03-11 1:58 ` [dpdk-dev] [PATCH v2 3/3] net/ice: disable ice DDP package " Pallavi Kadam
2021-03-25 16:55 ` Jie Zhou
2021-03-26 11:53 ` Ferruh Yigit
2021-03-28 2:02 ` Kadam, Pallavi
2021-04-02 1:26 ` [dpdk-dev] [PATCH v3 0/3] Support ice PMD " Pallavi Kadam
2021-04-02 1:26 ` [dpdk-dev] [PATCH v3 1/3] build: enable iavf base code to build on windows Pallavi Kadam
2021-04-02 1:26 ` [dpdk-dev] [PATCH v3 2/3] net/ice: build on Windows Pallavi Kadam
2021-04-02 1:26 ` Pallavi Kadam [this message]
2021-04-06 16:40 ` [dpdk-dev] [PATCH v3 0/3] Support ice PMD " Ferruh Yigit
2021-04-06 17:22 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210402012621.7944-4-pallavi.kadam@intel.com \
--to=pallavi.kadam@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=ranjit.menon@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).