From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 34E84A0548;
	Fri,  2 Apr 2021 01:03:42 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id AA9CA40F35;
	Fri,  2 Apr 2021 01:03:41 +0200 (CEST)
Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com
 [209.85.167.52]) by mails.dpdk.org (Postfix) with ESMTP id DF89140150
 for <dev@dpdk.org>; Fri,  2 Apr 2021 01:03:39 +0200 (CEST)
Received: by mail-lf1-f52.google.com with SMTP id g8so5109278lfv.12
 for <dev@dpdk.org>; Thu, 01 Apr 2021 16:03:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=+PtYFSIsnrVnwX2OGKBkbxuIF9IP7aQhTBbI5QsPke4=;
 b=Vtw/dXOrgQvR0CJlQLcYBugIhaosAK226Grt5pFgg/wLJ5qGS99+9yD7cuZiCuUEU+
 cV+pztZbtZB2tUACjHzkTCq92KI5ILabHOHcl0Pfae1vzTmgRxGUlE7Iz6cNlbBhthZG
 ZYBX/ETsE15Hvw+kV8LrsiRiIBzaPMYXjBB3R7PbX/uBmMyxrh7p/BKVUyNxH34footC
 P2iXvg0Esf9wRlGZn6u6TfCLltLXni48/9XsbvdhgB+RwrCepYh0YK2Ddr1L4k53GQP6
 1H1/FpnOkyz/LsdSl8GjGu3wl1MHM/IRAztN6JyrF1DLv3d8YsFp2xzAqsJg7YHmX9bo
 ECNA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=+PtYFSIsnrVnwX2OGKBkbxuIF9IP7aQhTBbI5QsPke4=;
 b=g+CNYt7bRPfW8amnbXFqnnhaAwuAOognZ4RHl/6/JRGUXiFOTlOHtetbgWqFRSznJI
 kFE5fy7+wAJtd1CDCbn4GUDVYayIN7ZvMGVaF7LTZroV5dEAx7xHkSpNvrkx5OjXeVU2
 jAzC9BuSYge/n545CHliwwu0+F4vgR2x+uWKDuz5B5CjxyMAhzA5dWhS32seeJOfJ3Ok
 q9+LQK78T2ckHxbXAxrU5TFppi0sJoirxMX8RPwwZ0zs94BIZ5GnhlYgcybHItdzyrr8
 80mMuHMP9q4FlkeMQqVuEn66y2IUDwaJOPkKL9xJ5Eu9BzKjj/xYt37bjeRw2I4RwBR4
 KnFQ==
X-Gm-Message-State: AOAM532yW1rMHqh0YCc71GcZ31KfK4O54Z/Gi1jTga4d2CmtFYkn/DnB
 XjmWI3w24fw5hZb4gbgZkko=
X-Google-Smtp-Source: ABdhPJw82sW8mzhCAhDjNdKd1VMWQLNEC/Zb3epw/f1O/XJmdEZLTp94stBsIEMfPcJdEi+yCGJF2Q==
X-Received: by 2002:a05:6512:2348:: with SMTP id
 p8mr6625610lfu.475.1617318219459; 
 Thu, 01 Apr 2021 16:03:39 -0700 (PDT)
Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru.
 [37.110.65.23])
 by smtp.gmail.com with ESMTPSA id j19sm677194lfb.15.2021.04.01.16.03.38
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 01 Apr 2021 16:03:38 -0700 (PDT)
Date: Fri, 2 Apr 2021 02:03:37 +0300
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Tyler Retzlaff <roretzla@linux.microsoft.com>, Jie Zhou
 <jizh@linux.microsoft.com>, Ranjit Menon <ranjit.menon@intel.com>, Beilei
 Xing <beilei.xing@intel.com>, Jeff Guo <jia.guo@intel.com>, Narcisa Ana
 Maria Vasile <navasile@linux.microsoft.com>, Dmitry Malloy
 <dmitrym@microsoft.com>, Pallavi Kadam <pallavi.kadam@intel.com>, Olivier
 Matz <olivier.matz@6wind.com>
Message-ID: <20210402020337.60701166@sovereign>
In-Reply-To: <5366968.186Eh59Hp8@thomas>
References: <20210320112733.13160-1-dmitry.kozliuk@gmail.com>
 <20210320130525.16452-1-dmitry.kozliuk@gmail.com>
 <20210320130525.16452-6-dmitry.kozliuk@gmail.com>
 <5366968.186Eh59Hp8@thomas>
X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v6 5/5] net: replace Windows networking shim
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2021-03-26 10:28 (UTC+0100), Thomas Monjalon:
> 20/03/2021 14:05, Dmitry Kozlyuk:
[...]
> > --- a/drivers/net/i40e/i40e_fdir.c
> > +++ b/drivers/net/i40e/i40e_fdir.c
> > @@ -22,6 +22,7 @@
> >  #include <rte_sctp.h>
> >  #include <rte_hash_crc.h>
> >  #include <rte_bitmap.h>
> > +#include <rte_os_internal.h>  
> 
> Why is it needed?

I deliberately put all shim definitions, like missing IPPROTO_* constants that
are used in this file, in <rte_os_internal.h> so that they are never exposed
to DPDK users. Other inclusions of this file have the same reason.