From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9228EA0548; Fri, 2 Apr 2021 01:10:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5BA5B40F35; Fri, 2 Apr 2021 01:10:25 +0200 (CEST) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by mails.dpdk.org (Postfix) with ESMTP id D5ACA40150 for ; Fri, 2 Apr 2021 01:10:23 +0200 (CEST) Received: by mail-lf1-f51.google.com with SMTP id m12so5141165lfq.10 for ; Thu, 01 Apr 2021 16:10:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=v+HKWDK6hMQ10Q2bCSuXZFn7Y6NZkEu0BW03wDkQo2E=; b=MRC0PsKjiaOziT3RAPS9DY7Ts+/+hE9hp60WTzcb3BoFkwthhEqqRyQh4dBjZ/SQKw a1M2JRXS8SLPvWV81pVWE9T/GbXytQMJ41BK18Qc3+x/1FDXqJRzGwErvRwKdiFllM2y oAwXMeK78ccb4ne0FyzR4pDz9avB1DAh8zcCPPnvMKxSDXUQxzH8mX9ByjVp5ax+bLAY plORDJ7IgLM6gYIKtj3jhcB8z531oMkXWmyaKzf2HPrtl8Wkwr86EW+PrA3YSXvDRZTf QD6LLvle2qjQkO1Yrd9JapUnRH4oqh+QtRS4iT6EONwpNUV4pb+qv7hHvj9MfMwSvY5z AJdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v+HKWDK6hMQ10Q2bCSuXZFn7Y6NZkEu0BW03wDkQo2E=; b=thPKqOMYe9KmXhySzgK/rvnIMzd2ESDT49fPeCLC6DoeSnRqq2LnalDCEXAE07MMs+ QWJ1CTtqhOgzk1vplHFqOyRvPwnyK48L7Le1kGOt5JW9/uhWo5DloeCRuoAJup7oMEkU lE+Mn79qTwP3Ua4CsIjveqqozsGKClH0jgyemJNr1eF1hVVDpCu9xhb16U147sA92LVX twav8zm2iS/5Ek5IcFBC18RvDc8aF2LRjuF5iNpV1JHH3cye/nDAuPFDoUATf2P/q7c6 IxszRhB94GcLNQD5r08z8HbW1ra2UsOqFDGSHRybv29xZ4DZ5ZbhOuhgVugnt0ebykyY Yfww== X-Gm-Message-State: AOAM530APIsSA9aQ/ED+nGRsOzHffiETSsNtqKoCJCC+pSM/FWTec7ZN jVzVR1WInv3BokgdyVWgPwM= X-Google-Smtp-Source: ABdhPJxpTcAM2Xjut8UnKuMwjLztdYNWZ5hw21ro1SgA2wBcsaEM2BSMwfdbsRXoqN9tWWltN6ooeQ== X-Received: by 2002:a05:6512:ba0:: with SMTP id b32mr6998163lfv.127.1617318623388; Thu, 01 Apr 2021 16:10:23 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id i4sm672494lfv.161.2021.04.01.16.10.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Apr 2021 16:10:22 -0700 (PDT) Date: Fri, 2 Apr 2021 02:10:21 +0300 From: Dmitry Kozlyuk To: Thomas Monjalon Cc: Nick Connolly , Bruce Richardson , Dmitry Malloy , Jie Zhou , Narcisa Ana Maria Vasile , Olivier Matz , Pallavi Kadam , Tyler Retzlaff , dev@dpdk.org Message-ID: <20210402021021.5cfaf1c6@sovereign> In-Reply-To: <5131236.apLr1G0U0s@thomas> References: <20210320112733.13160-1-dmitry.kozliuk@gmail.com> <8471582.rvcOfDAzBe@thomas> <5131236.apLr1G0U0s@thomas> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v6 3/5] eal: make OS shims internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-03-31 23:55 (UTC+0200), Thomas Monjalon: > 31/03/2021 23:45, Nick Connolly: > > > > > > I don't understand your point. > > > I am just proposing to allow some apps to explicitly include the shim > > > for their convenience in case they are fully based on DPDK and > > > understand the risk of conflict with some other code. =20 > >=20 > >=20 > > Agreed - there=E2=80=99s no harm in doing so. > >=20 > > My point was simply that for a non-trivial application I suspect it will > > have limited value due to the sorts of conflicts that are likely to ari= se. =20 >=20 > OK yes. > If we expose this header, we should bring it with a disclaimer. Let's now avoid "internal" (rte_os_shim?), but expose it later, if ever: 1. The concept of "not so public" API is new, probably a techboard subject. 2. We may want devtools checks against including it from public headers.