From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27506A0548; Sun, 4 Apr 2021 01:41:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 99EAC4068C; Sun, 4 Apr 2021 01:41:39 +0200 (CEST) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by mails.dpdk.org (Postfix) with ESMTP id 74D1E40041 for ; Sun, 4 Apr 2021 01:41:38 +0200 (CEST) Received: by mail-lf1-f48.google.com with SMTP id d13so12425790lfg.7 for ; Sat, 03 Apr 2021 16:41:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1xgXWWjo0K0MZFTIGPz4gYyfY93FYezgxsLZenDkZCM=; b=oCMz9KOeffMVchGaGAIPX/TTLs91JoTYn8MK9kHnwuoU6MhWOtoXA4H2T57K+4YK+M d5ZfUQ4b17TNOeTbj30DijPW5MWPY6SiTLyNU+vrsQPnweh+GrOTatBkmMAzIsxifyv2 pjzXMCr1CZg6fo6ygLg9xZ6qGLJdgRxMlRjyMWnnbCAj0vxvrvIueG9E21TgvCDkgFh+ YLQIvXis0vXJyn62iTELcfzxHndym3TqMnBQQ8PZM56zT/vAopnqPJN2+Ebsrp24d+vI K7zHFlRjpUCmBh34DBDd4mr5dQBxv8BEm6MP/DMS2NQr9z1d+C7iq9drq6NNHD8Kz6/t 3/xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1xgXWWjo0K0MZFTIGPz4gYyfY93FYezgxsLZenDkZCM=; b=GRAxE2kiV1se+J/5xFKw8iudAgSLXGffzyCBhW3f3nBvlu/ZO0LCNUN2eLrF0SLRg1 JQqtDNb3+jtR6urhCEA76AFS7EtkfRGBWa8bV8RW4to28qW+UxgReUf3tAIgg6MOoirt cmehHOiGxNkaIvQRut+WPG4LE07ul0iWGPHP66pCqIFAUzYygWKwYtsmWp0PDanJaxBv R08Ch69UyulzOjUWCJZIc4Px8LnrVAwtdfQ3Vt559ySEhHeb3FmQ4Y9ov7lDCe1yi6FF r1YmVAcHMBUhT4TwdD194i5JANyy7hxN3xshX8Pwp0oa31wvl51om22B1TsI8IiQsfSX 0lbA== X-Gm-Message-State: AOAM5325LWQTJep+yw+HotWuTzFzi+y/COZw9MoOWsZRIZQudjKq8LyP aXYhh/KQRr9RRpFonLZS90xCrXhh5JGUzw== X-Google-Smtp-Source: ABdhPJyzlXNBE3GroUIY7PlttBOxk7V7pAQudNXLQkkm1els4wj7IwiK51Ks55kSB4e3w5wdFjwvzA== X-Received: by 2002:a19:521a:: with SMTP id m26mr13263539lfb.56.1617493297501; Sat, 03 Apr 2021 16:41:37 -0700 (PDT) Received: from localhost.localdomain (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id f23sm1374927lja.43.2021.04.03.16.41.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Apr 2021 16:41:36 -0700 (PDT) From: Dmitry Kozlyuk To: dev@dpdk.org Cc: Tyler Retzlaff , Jie Zhou , Nick Connolly , Dmitry Kozlyuk Date: Sun, 4 Apr 2021 02:41:24 +0300 Message-Id: <20210403234129.20296-1-dmitry.kozliuk@gmail.com> X-Mailer: git-send-email 2.29.3 In-Reply-To: <20210320130525.16452-1-dmitry.kozliuk@gmail.com> References: <20210320130525.16452-1-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v7 0/5] eal/windows: do not expose POSIX symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Windows, EAL contains two sets of functions and macros for POSIX compatibility: and a networking shim (socket headers). The latter conflicts with system headers and should not exist. Exposing the former from EAL can break consumer own POSIX compatibility layer and is against standards in general. Hide these symbols from external consumers, while keeping them available for DPDK code. v7: * Rearrange patches, improve wording, fix typo. * rte_os_internal.h -> rte_os_shim.h for possible later exposure * Remove unnecessary blank lines. Dmitry Kozlyuk (5): eal: add sleep API eal/windows: hide asprintf() shim eal: make OS shims internal net: work around s_addr macro on Windows net: provide IP-related API on any OS drivers/bus/pci/private.h | 4 +- drivers/bus/vdev/vdev_private.h | 2 + drivers/common/mlx5/mlx5_common.h | 1 + drivers/net/i40e/i40e_ethdev.c | 1 + drivers/net/i40e/i40e_fdir.c | 1 + drivers/net/mlx5/mlx5.h | 1 - drivers/net/mlx5/mlx5_flow.c | 4 +- drivers/net/mlx5/mlx5_flow.h | 3 +- drivers/net/mlx5/mlx5_mac.c | 1 - examples/cmdline/commands.c | 5 -- examples/cmdline/parse_obj_list.c | 2 - lib/librte_cmdline/cmdline.c | 5 -- lib/librte_cmdline/cmdline_os_windows.c | 2 - lib/librte_cmdline/cmdline_parse.c | 2 - lib/librte_cmdline/cmdline_parse_etheraddr.c | 6 -- lib/librte_cmdline/cmdline_parse_ipaddr.c | 6 -- lib/librte_cmdline/cmdline_parse_ipaddr.h | 2 +- lib/librte_cmdline/cmdline_private.h | 1 + lib/librte_cmdline/cmdline_socket.c | 4 - lib/librte_eal/common/eal_common_config.c | 1 - lib/librte_eal/common/eal_common_errno.c | 4 + lib/librte_eal/common/eal_common_options.c | 2 +- lib/librte_eal/common/eal_common_timer.c | 5 +- lib/librte_eal/common/eal_internal_cfg.h | 1 + lib/librte_eal/common/eal_private.h | 11 +++ lib/librte_eal/freebsd/include/rte_os_shim.h | 14 +++ lib/librte_eal/include/rte_thread.h | 11 +++ lib/librte_eal/linux/include/rte_os_shim.h | 14 +++ lib/librte_eal/rte_eal_exports.def | 2 + lib/librte_eal/unix/rte_thread.c | 10 ++- lib/librte_eal/version.map | 1 + lib/librte_eal/windows/eal.c | 30 +++++++ lib/librte_eal/windows/eal_hugepages.c | 1 - lib/librte_eal/windows/eal_lcore.c | 1 - lib/librte_eal/windows/eal_memalloc.c | 1 - lib/librte_eal/windows/eal_thread.c | 9 +- lib/librte_eal/windows/include/arpa/inet.h | 30 ------- lib/librte_eal/windows/include/netinet/in.h | 38 -------- lib/librte_eal/windows/include/netinet/ip.h | 10 --- lib/librte_eal/windows/include/rte_os.h | 92 +------------------- lib/librte_eal/windows/include/rte_os_shim.h | 36 ++++++++ lib/librte_eal/windows/include/sys/socket.h | 24 ----- lib/librte_ethdev/ethdev_private.h | 2 + lib/librte_ethdev/rte_ethdev.c | 12 +-- lib/librte_ethdev/rte_ethdev_core.h | 1 - lib/librte_kvargs/rte_kvargs.c | 1 + lib/librte_net/rte_ether.h | 26 ++++-- lib/librte_net/rte_ip.h | 7 ++ lib/librte_net/rte_net.c | 1 + 49 files changed, 196 insertions(+), 255 deletions(-) create mode 100644 lib/librte_eal/freebsd/include/rte_os_shim.h create mode 100644 lib/librte_eal/linux/include/rte_os_shim.h delete mode 100644 lib/librte_eal/windows/include/arpa/inet.h delete mode 100644 lib/librte_eal/windows/include/netinet/in.h delete mode 100644 lib/librte_eal/windows/include/netinet/ip.h create mode 100644 lib/librte_eal/windows/include/rte_os_shim.h delete mode 100644 lib/librte_eal/windows/include/sys/socket.h -- 2.29.3