From: Stephen Hemminger <stephen@networkplumber.org>
To: oulijun <oulijun@huawei.com>
Cc: <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH V2] ethdev: add queue state when retrieve queue information
Date: Mon, 5 Apr 2021 18:55:10 -0700 [thread overview]
Message-ID: <20210405185510.02ee53fb@hermes.local> (raw)
In-Reply-To: <3dfa2e6b-91b2-da43-a20a-84b8de362fad@huawei.com>
On Tue, 6 Apr 2021 08:49:04 +0800
oulijun <oulijun@huawei.com> wrote:
> > /**
> > + * RX/TX queue states
> > + */
> > +#define RTE_ETH_QUEUE_STATE_STOPPED 0
> > +#define RTE_ETH_QUEUE_STATE_STARTED 1
> > +#define RTE_ETH_QUEUE_STATE_HAIRPIN 2
These could be an enum?
> > +/**
> > * Ethernet device RX queue information structure.
> > * Used to retrieve information about configured queue.
> > */
> > @@ -1591,6 +1598,8 @@ struct rte_eth_rxq_info {
> > uint8_t scattered_rx; /**< scattered packets RX supported. */
There is a one byte hole here waiting to be used.
Why not use that?
> > uint16_t nb_desc; /**< configured number of RXDs. */
> > uint16_t rx_buf_size; /**< hardware receive buffer size. */
> > + /**< Queues state: STARTED(1) / STOPPED(0). */
> > + uint8_t queue_state;
> > } __rte_cache_min_aligned;
next prev parent reply other threads:[~2021-04-06 1:55 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 12:25 [dpdk-dev] [PATCH] " Lijun Ou
2021-03-22 9:22 ` Ferruh Yigit
2021-03-22 9:38 ` Kinsella, Ray
2021-03-22 9:39 ` oulijun
2021-03-22 14:49 ` Andrew Rybchenko
2021-03-22 15:45 ` Ananyev, Konstantin
2021-03-22 16:02 ` Andrew Rybchenko
2021-03-22 16:53 ` Ananyev, Konstantin
2021-03-22 17:07 ` Andrew Rybchenko
2021-03-22 18:53 ` Ananyev, Konstantin
2021-03-23 10:13 ` Ferruh Yigit
2021-03-23 10:19 ` Ferruh Yigit
2021-03-23 11:07 ` Ananyev, Konstantin
2021-03-25 10:01 ` oulijun
2021-03-25 10:18 ` Ananyev, Konstantin
2021-03-25 11:09 ` [dpdk-dev] [PATCH V2] " Lijun Ou
2021-04-06 0:49 ` oulijun
2021-04-06 1:55 ` Stephen Hemminger [this message]
2021-04-14 10:09 ` Ferruh Yigit
2021-04-06 14:02 ` Ananyev, Konstantin
2021-04-14 10:40 ` Ferruh Yigit
2021-04-14 10:56 ` Ananyev, Konstantin
2021-04-15 2:40 ` [dpdk-dev] [PATCH V3] " Lijun Ou
2021-04-15 12:33 ` Ferruh Yigit
2021-04-15 12:36 ` Thomas Monjalon
2021-04-15 12:45 ` Ferruh Yigit
2021-04-15 13:34 ` Thomas Monjalon
2021-04-16 0:58 ` [dpdk-dev] [Linuxarm] " oulijun
2021-04-16 7:31 ` Ferruh Yigit
2021-04-16 8:46 ` [dpdk-dev] [PATCH V4] " Lijun Ou
2021-04-16 8:58 ` Thomas Monjalon
2021-04-16 9:41 ` Ferruh Yigit
2021-04-16 9:57 ` Thomas Monjalon
2021-04-23 11:08 ` Kinsella, Ray
2021-04-25 16:42 ` Thomas Monjalon
2021-04-26 9:48 ` Kinsella, Ray
2021-04-16 9:55 ` oulijun
2021-04-16 9:19 ` Ananyev, Konstantin
2021-04-17 3:09 ` [dpdk-dev] [PATCH V5] " Lijun Ou
2021-04-17 22:00 ` Ferruh Yigit
2021-04-19 1:39 ` oulijun
2021-04-19 2:04 ` oulijun
2021-04-19 2:03 ` [dpdk-dev] [PATCH V6] " Lijun Ou
2021-04-19 8:41 ` Thomas Monjalon
2021-04-19 8:58 ` oulijun
2021-04-19 8:57 ` [dpdk-dev] [PATCH v7] " Lijun Ou
2021-04-19 9:03 ` Thomas Monjalon
2021-04-19 10:48 ` Ferruh Yigit
2021-04-23 11:17 ` [dpdk-dev] [PATCH V5] " Kinsella, Ray
2021-04-23 11:26 ` Ananyev, Konstantin
2021-04-23 15:43 ` Kinsella, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210405185510.02ee53fb@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=oulijun@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).