From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85F17A034F; Tue, 6 Apr 2021 12:18:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 05B10140F8F; Tue, 6 Apr 2021 12:18:48 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id E8750140F7F for ; Tue, 6 Apr 2021 12:18:45 +0200 (CEST) IronPort-SDR: 6aZb4Hcts7uZewZvoVBjHh/SBegmxjjCnMvJMkPa2O1Kg4ejc7ioj6K/8+NrA1ECdz02LH64sG 4X26wZiRw1sQ== X-IronPort-AV: E=McAfee;i="6000,8403,9945"; a="180568972" X-IronPort-AV: E=Sophos;i="5.81,309,1610438400"; d="scan'208";a="180568972" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2021 03:18:43 -0700 IronPort-SDR: 2gYyyqO/7+3h5d3JdKaxM6K71q9eHCp1j9rn0XqrN+KglIcAlB/T9V7j3htIT0Mg7ItIn/iX9h ECt2xywSsG5A== X-IronPort-AV: E=Sophos;i="5.81,309,1610438400"; d="scan'208";a="396174590" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.31.235]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 06 Apr 2021 03:18:42 -0700 Date: Tue, 6 Apr 2021 11:18:38 +0100 From: Bruce Richardson To: David Marchand Cc: dev@dpdk.org, Ciara Power Message-ID: <20210406101838.GA551@bricha3-MOBL.ger.corp.intel.com> References: <20210406092545.24465-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210406092545.24465-1-david.marchand@redhat.com> Subject: Re: [dpdk-dev] [PATCH] eal: fix telemetry logtype registration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 06, 2021 at 11:25:45AM +0200, David Marchand wrote: > rte_log_register_type_and_pick_level() returns an int. > Casting to a uin32_t will make us miss the -1 passed in case of failure. > > Fixes: 37b881a96194 ("telemetry: use log function from pointer") > > Signed-off-by: David Marchand > --- Acked-by: Bruce Richardson