From: Renata Saiakhova <Renata.Saiakhova@ekinops.com>
Cc: dev@dpdk.org, Renata Saiakhova <Renata.Saiakhova@ekinops.com>
Subject: [dpdk-dev] [PATCH v5 0/1] eal/interrupts: add synchronous wrapper around unregister
Date: Tue, 6 Apr 2021 16:46:13 +0200 [thread overview]
Message-ID: <20210406144614.3394-1-Renata.Saiakhova@ekinops.com> (raw)
For pci_vfio, while removing the device by rte_dev_remove(),
pci_vfio_disable_notifier() will call rte_intr_callback_unregister(),
which may return -EAGAIN, if an interrupt source (kernel) has some active
callbacks right now. As a result, the callback (req notifier) can be never unregistered,
and the corresponding descriptor (vfio_req_intr_handle.fd) can be never closed.
The kernel will continuously try to notify the user space using req notifier, but as
the device is already removed, in this case it even cannot find a bus for that
device, the log is full of messages "EAL: Cannot find bus for device (XX:XX.X)"
v5:
Re-spin with windows update and 21.05 edition
v4:
* Typo spelling in commit message
v3:
* Subject line reworded
v2:
* Use only for pci-vfio in pci_vfio_disable_notifier()
Renata Saiakhova (1):
eal/interrupts: add synchronous wrapper around unregister
drivers/bus/pci/linux/pci_vfio.c | 2 +-
lib/librte_eal/freebsd/eal_interrupts.c | 12 ++++++++++++
lib/librte_eal/include/rte_interrupts.h | 25 +++++++++++++++++++++++++
lib/librte_eal/linux/eal_interrupts.c | 12 ++++++++++++
lib/librte_eal/version.map | 1 +
lib/librte_eal/windows/eal_interrupts.c | 8 ++++++++
6 files changed, 59 insertions(+), 1 deletion(-)
--
2.17.2
next reply other threads:[~2021-04-06 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 14:46 Renata Saiakhova [this message]
2021-04-06 14:46 ` [dpdk-dev] [PATCH v5 1/1] " Renata Saiakhova
2021-04-07 9:12 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210406144614.3394-1-Renata.Saiakhova@ekinops.com \
--to=renata.saiakhova@ekinops.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).