From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 524B8A0546;
	Wed,  7 Apr 2021 01:29:53 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E783E407FF;
	Wed,  7 Apr 2021 01:29:52 +0200 (CEST)
Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com
 [209.85.167.47]) by mails.dpdk.org (Postfix) with ESMTP id 320F94069F
 for <dev@dpdk.org>; Wed,  7 Apr 2021 01:29:52 +0200 (CEST)
Received: by mail-lf1-f47.google.com with SMTP id j18so1605459lfg.5
 for <dev@dpdk.org>; Tue, 06 Apr 2021 16:29:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=pjKeGb6kOjF7kC4V5FaBgnaM5ItTFad4AGcXGHiIRtk=;
 b=Sjlna6AOBxy6eFD+W8CNCyJtpeTn7FH7ECw5WAhihaIDItZvS7PM5M9EokqRTLlhj3
 cuD+Zs7NP4pEorhdJlMjcHXp7ri7GYPen1/bKawxCsLK0KHcTTYbuxCXT0bTndW0jhtT
 6Pif4P7O270ySN9syhrOoPxDtsOUZXVA/ENRC1BwuEx8yqFbdMlNW6U79Soq1cTucJCm
 V1Tiv5ML9uWYIsNx6sH8cd2o6OfPYmJmqOnwJ7SRH8UOa/0HHYQTtTtgwbCLfQmlmEZ1
 lI1Bimq6y+zuU5hSo6LyIE3fvYQKiv9O/80UhqABRxvfBFHVhd9beLxSL8hheCJrXV0l
 vYtg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=pjKeGb6kOjF7kC4V5FaBgnaM5ItTFad4AGcXGHiIRtk=;
 b=pEAAMRT12ZszFPdFcp9OpiiaJZNppUBoH543pkpnHCswjvAFRViEFo/FRamh+mnaM+
 xraSz+DQSIgD/S8qf7rYiFKpIpGtzrQRrKdB29lhPvHsOpctHhzIbXL/GwwVxiY4ZgGD
 ghlJVTK3M4oHTyofqahraej5R8TxUJZdDwbMVQGauY+EHB/jkbQOJ9engs/JV2dwNPQ0
 ngfWRdfGAe/m3t7FUYzumCIdb0YN0S7we7li3W/o+eEnk1b4oi3ObxNsvQpoeJCLQRvy
 Bxy3oH6CP3/kpmnnRh+22yVyblfRVwpjyH6WSOhhrGfqQS+BynEkFH2upV59iessBL6i
 XcAA==
X-Gm-Message-State: AOAM531ux8fcRVYwvGo56wyO2CaVcBNI1uVp7Qz+AK22DudkYzef6uu0
 vMZIGg7NIVhMRIpw0U2pDSw=
X-Google-Smtp-Source: ABdhPJzfwqOT6X0PphhRwtrQhYjYbV4CFfMmusI/a+DBSL24g9PSU0/3/9A4bDAcEHtu40w7mbQWdA==
X-Received: by 2002:a05:6512:210b:: with SMTP id
 q11mr372312lfr.469.1617751791761; 
 Tue, 06 Apr 2021 16:29:51 -0700 (PDT)
Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru.
 [37.110.65.23])
 by smtp.gmail.com with ESMTPSA id z30sm99536lfg.162.2021.04.06.16.29.50
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 06 Apr 2021 16:29:50 -0700 (PDT)
Date: Wed, 7 Apr 2021 02:29:49 +0300
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Morten =?UTF-8?B?QnLDuHJ1cA==?= <mb@smartsharesystems.com>
Cc: <dev@dpdk.org>, "Tyler Retzlaff" <roretzla@linux.microsoft.com>, "Jie
 Zhou" <jizh@linux.microsoft.com>, "Nick Connolly"
 <nick.connolly@mayadata.io>, "Khoa To" <khot@microsoft.com>, "Ray Kinsella"
 <mdr@ashroe.eu>, "Narcisa Ana Maria Vasile" <navasile@linux.microsoft.com>,
 "Dmitry Malloy" <dmitrym@microsoft.com>, "Pallavi Kadam"
 <pallavi.kadam@intel.com>, "Neil Horman" <nhorman@tuxdriver.com>
Message-ID: <20210407022949.7dc80aa4@sovereign>
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35C616C0@smartserver.smartshare.dk>
References: <20210320130525.16452-1-dmitry.kozliuk@gmail.com>
 <20210403234129.20296-1-dmitry.kozliuk@gmail.com>
 <20210403234129.20296-2-dmitry.kozliuk@gmail.com>
 <98CBD80474FA8B44BF855DF32C47DC35C616C0@smartserver.smartshare.dk>
X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [dpdk-dev] [PATCH v7 1/5] eal: add sleep API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2021-04-06 16:34 (UTC+0200), Morten Br=C3=B8rup:
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Dmitry Kozlyuk
> > Sent: Sunday, April 4, 2021 1:41 AM
> >=20
> > POSIX sleep(3) is missing from Windows.
> > Add generic rte_thread_sleep() to suspend current OS thread.
> >=20
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> > Acked-by: Khoa To <khot@microsoft.com>
> > Acked-by: Ray Kinsella <mdr@ashroe.eu> =20
>=20
> How is this better than the rte_delay_us_sleep() function in rte_cycles.

Honestly, I just assumed the sleep() shim existed for a reason.
Now that you pointed to it, I think indeed no new API is needed.

I wonder why rte_delay_us_sleep() is not used throughout DPDK.
Should their usages be converted as soon as code is enabled for Windows?