From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 282A5A0A0F;
Thu, 8 Apr 2021 00:23:01 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id A88FD140FB8;
Thu, 8 Apr 2021 00:23:00 +0200 (CEST)
Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com
[209.85.208.175])
by mails.dpdk.org (Postfix) with ESMTP id 5E7D940698
for <dev@dpdk.org>; Thu, 8 Apr 2021 00:22:59 +0200 (CEST)
Received: by mail-lj1-f175.google.com with SMTP id u9so22586186ljd.11
for <dev@dpdk.org>; Wed, 07 Apr 2021 15:22:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=MSbq2G9Cd0dROuYro6fyYeqE4oqMbpI/EwOKgZC94to=;
b=pdd9nyETb4KFfYIIDNpzrHc/RYFcQsJlDJmQnt7VlsyG9WNivbXyz7qhZvPsCEte8i
Z+wbhPW0VpCLhVQSh2N4t/LxXnH6WEnWTGl2K4gXJKpngvUjVtDM4Kxa+FqmXrmvZWSs
px/S4fy+mVkSue9tQXfnVjML8UP8Z5IgnsFEgzBJuI0vqhlkJFRKBuCxJYqTOnsSWCd1
GLE9XIldHJUue8n0hJGSq69TR8K3g8/P7rUzNpTY2n/bGEB1msL8v3aOpD1Mrhw8tCO2
XQwY8Yhu7Z15+BgYYavZnKJQPKSJmhoaOqDh/lzro+zq+m3nxtzIAZOJ9dGsJS5Ip3Ve
noJw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=MSbq2G9Cd0dROuYro6fyYeqE4oqMbpI/EwOKgZC94to=;
b=fwvU98TlNW5lAs/QdF4jbzw74IrcTvxmqeLOVSYMA0E/SHTGOI/5AzAoM0RPaqAeWZ
Xvh4cHveDL8h/iZlGWMvF5JXlRRkBfQYnXXLFd169NqdWwbNc9fvcRoq21f4K1yNdjHY
UltU5YbeGSA1YsVVkoNCmf5DiNOYbvNYByFtwHCmKy9rsezszlM07mp/VEaSs45Bspaf
HMOFYry1bkDrryMMljXqzrKUCqSvkuEWSjtuhl7jX74f0TouzZdwgcHW5eyVnB7rzqRM
9C8nffDMTgE6MSbMAnUEuaZPHepEBX/fyzDyP5ifh102kicbxgCFeXKq0NhFmaeP10m2
QUVg==
X-Gm-Message-State: AOAM530rIE40uBr+elCERYSyJJloIStdg6GlL6+t8fZotaWO8eMe2QmM
qFjSnEyNCYbPVPIh50OOurXwUHd6QBsleg==
X-Google-Smtp-Source: ABdhPJzhA7MtLRU+tLMMV+80lBCCnk0FnhxH9s/ZnDjgWuHHPLugwHnWkUXMzFWj3rEUpyE20QSe2g==
X-Received: by 2002:a2e:5c47:: with SMTP id q68mr3580336ljb.314.1617834178462;
Wed, 07 Apr 2021 15:22:58 -0700 (PDT)
Received: from localhost.localdomain (broadband-37-110-65-23.ip.moscow.rt.ru.
[37.110.65.23])
by smtp.gmail.com with ESMTPSA id u27sm441965lfk.254.2021.04.07.15.22.57
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 07 Apr 2021 15:22:57 -0700 (PDT)
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: dev@dpdk.org
Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>,
Jie Zhou <jizh@linux.microsoft.com>,
Nick Connolly <nick.connolly@mayadata.io>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Date: Thu, 8 Apr 2021 01:22:45 +0300
Message-Id: <20210407222249.6729-1-dmitry.kozliuk@gmail.com>
X-Mailer: git-send-email 2.29.3
In-Reply-To: <20210403234129.20296-1-dmitry.kozliuk@gmail.com>
References: <20210403234129.20296-1-dmitry.kozliuk@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH v8 0/4] eal/windows: do not expose POSIX symbols
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Windows, EAL contains two sets of functions and macros for POSIX
compatibility: <rte_os.h> and a networking shim (socket headers).
The latter conflicts with system headers and should not exist.
Exposing the former from EAL can break consumer own POSIX compatibility
layer and is against standards in general. Hide these symbols from
external consumers, while keeping them available for DPDK code.
v8:
* Drop rte_thread_sleep API, use rte_delay_us_sleep (Morten Brørup).
v7:
* Rearrange patches, improve wording, fix typo.
* rte_os_internal.h -> rte_os_shim.h for possible later exposure
* Remove unnecessary blank lines.
*** BLURB HERE ***
Dmitry Kozlyuk (4):
eal/windows: hide asprintf() shim
eal: make OS shims internal
net: work around s_addr macro on Windows
net: provide IP-related API on any OS
drivers/bus/pci/private.h | 4 +-
drivers/bus/vdev/vdev_private.h | 2 +
drivers/common/mlx5/mlx5_common.h | 1 +
drivers/net/i40e/i40e_ethdev.c | 1 +
drivers/net/i40e/i40e_fdir.c | 1 +
drivers/net/mlx5/mlx5.h | 1 -
drivers/net/mlx5/mlx5_flow.c | 4 +-
drivers/net/mlx5/mlx5_flow.h | 3 +-
drivers/net/mlx5/mlx5_mac.c | 1 -
examples/cmdline/commands.c | 5 --
examples/cmdline/parse_obj_list.c | 2 -
lib/librte_cmdline/cmdline.c | 5 --
lib/librte_cmdline/cmdline_os_windows.c | 2 -
lib/librte_cmdline/cmdline_parse.c | 2 -
lib/librte_cmdline/cmdline_parse_etheraddr.c | 6 --
lib/librte_cmdline/cmdline_parse_ipaddr.c | 6 --
lib/librte_cmdline/cmdline_parse_ipaddr.h | 2 +-
lib/librte_cmdline/cmdline_private.h | 1 +
lib/librte_cmdline/cmdline_socket.c | 4 -
lib/librte_eal/common/eal_common_config.c | 1 -
lib/librte_eal/common/eal_common_errno.c | 4 +
lib/librte_eal/common/eal_common_options.c | 2 +-
lib/librte_eal/common/eal_common_timer.c | 4 +-
lib/librte_eal/common/eal_internal_cfg.h | 1 +
lib/librte_eal/common/eal_private.h | 11 +++
lib/librte_eal/freebsd/include/rte_os_shim.h | 14 +++
lib/librte_eal/linux/include/rte_os_shim.h | 14 +++
lib/librte_eal/windows/eal.c | 30 +++++++
lib/librte_eal/windows/eal_hugepages.c | 1 -
lib/librte_eal/windows/eal_lcore.c | 1 -
lib/librte_eal/windows/eal_memalloc.c | 1 -
lib/librte_eal/windows/include/arpa/inet.h | 30 -------
lib/librte_eal/windows/include/netinet/in.h | 38 --------
lib/librte_eal/windows/include/netinet/ip.h | 10 ---
lib/librte_eal/windows/include/rte_os.h | 92 +-------------------
lib/librte_eal/windows/include/rte_os_shim.h | 36 ++++++++
lib/librte_eal/windows/include/sys/socket.h | 24 -----
lib/librte_ethdev/ethdev_private.h | 2 +
lib/librte_ethdev/rte_ethdev.c | 12 +--
lib/librte_ethdev/rte_ethdev_core.h | 1 -
lib/librte_kvargs/rte_kvargs.c | 1 +
lib/librte_net/rte_ether.h | 26 ++++--
lib/librte_net/rte_ip.h | 7 ++
lib/librte_net/rte_net.c | 1 +
44 files changed, 164 insertions(+), 253 deletions(-)
create mode 100644 lib/librte_eal/freebsd/include/rte_os_shim.h
create mode 100644 lib/librte_eal/linux/include/rte_os_shim.h
delete mode 100644 lib/librte_eal/windows/include/arpa/inet.h
delete mode 100644 lib/librte_eal/windows/include/netinet/in.h
delete mode 100644 lib/librte_eal/windows/include/netinet/ip.h
create mode 100644 lib/librte_eal/windows/include/rte_os_shim.h
delete mode 100644 lib/librte_eal/windows/include/sys/socket.h
--
2.29.3