From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F29D0A0579; Thu, 8 Apr 2021 16:20:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC92D1410B4; Thu, 8 Apr 2021 16:20:15 +0200 (CEST) Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by mails.dpdk.org (Postfix) with ESMTP id 289224068B for ; Thu, 8 Apr 2021 16:20:15 +0200 (CEST) Received: by mail-wr1-f43.google.com with SMTP id b9so2358586wrs.1 for ; Thu, 08 Apr 2021 07:20:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=z6H0v/gSsjD8MQrru4WU5GpuDLgBzXqMUtDHiJ6gd4g=; b=VgVrNChe0UA91uCCUQhnVHZw80ktr+7cZkRkdQK0PnvPsCrcdcZJ/C2u5aojrp0h03 rwqIVhHd2R2Clvi7++yHLOfxlsGAHO23aCYIxOQtw3cCcJkg6VJNwMbmocXz5Isg1vHs +da0qhEj4KPlPuIiWCJzxjOyujhdNwpNeCfI9MFaHKZoTJM+CrodG4/4f8s2vQfkQTRx XCVP+Yvhsi+mBJckDSlDluZFSGwRdjFkeOz3qHeR15cfc3MC2P+MUsocjP7l1Hydbvyb 9RcZWP4oZEEYd7l55bjchHbFVylBNgBgG4dLngluvjzwsi5f/FrA7nh3b+94Yl3jsor3 Khow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=z6H0v/gSsjD8MQrru4WU5GpuDLgBzXqMUtDHiJ6gd4g=; b=YoSH9G/lQ5xuL08t+GI6+cRZiVYi0N07rLTZ4GaYawT2BuFFI12BHWwCWxn1EgpAct Z6YcN5jfClXpQ5F2oYNlT9KDxmaiEAOxZ4oyIcU1Qgs04H7ik6szq0d4+LpY6BwC1pEk zZHWsM+td/2s/BfRFeeMx4ynaDqs88k9af8N81V2ZdJvR9VvL7FaYNDbiM4FNj2i16Je fI3CfluqdFdrcOfFU2N/tON45ZsVsJxkdN2ZW+AfmTxsp3G9yUcOR3FYvR0aZGFj2VO1 xmURS8b/oMZAMVW3DXsx8JmoK6p2Fh2q0s3SegatLzFP934EHCm7e2/UhgvMljxoez3b 1mnw== X-Gm-Message-State: AOAM530aG7iIFIYucACIp3hmyN29UkApMBw9ZjM9sJ3ysfZPUp2WWBHn Q33/MaVccyN7GW8Ah8HMZ7sQ9g== X-Google-Smtp-Source: ABdhPJwF7+qCRGK+SKoxUNi5p+0dxGSpGMo/TJ+d1cQnRdYoI7o5iFuBgNtqikYvFrBFhDJXyuhejw== X-Received: by 2002:a5d:4bcc:: with SMTP id l12mr11806408wrt.343.1617891614890; Thu, 08 Apr 2021 07:20:14 -0700 (PDT) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id k7sm38940828wrd.24.2021.04.08.07.20.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Apr 2021 07:20:14 -0700 (PDT) Date: Thu, 8 Apr 2021 16:20:13 +0200 From: Olivier Matz To: Luc Pelletier Cc: jianfeng.tan@intel.com, Honnappa.Nagarahalli@arm.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20210408142013.GA1650@platinum> References: <20210407201603.149234-2-lucp.at.work@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210407201603.149234-2-lucp.at.work@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH 2/2] eal: fix hang in ctrl thread creation error logic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Luc, On Wed, Apr 07, 2021 at 04:16:06PM -0400, Luc Pelletier wrote: > The affinity of a control thread is set after it has been launched. If > setting the affinity fails, pthread_cancel is called followed by a call > to pthread_join, which can hang forever if the thread's start routine > doesn't call a pthread cancellation point. > > This patch modifies the logic so that the control thread exits > gracefully if the affinity cannot be set successfully and removes the > call to pthread_cancel. > > Fixes: 6383d26 ("eal: set name when creating a control thread") > Cc: olivier.matz@6wind.com > Cc: stable@dpdk.org > > Signed-off-by: Luc Pelletier Thank you for these 2 fixes. Note the the title of your patches do not contain the version (should have been v8?). I don't know how critical it is for commiters. Acked-by: Olivier Matz