DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v1] net/ice: add invalid RSS combinations
@ 2021-04-08 15:54 Liulingyu
  2021-04-13  5:15 ` Zhang, Qi Z
  0 siblings, 1 reply; 2+ messages in thread
From: Liulingyu @ 2021-04-08 15:54 UTC (permalink / raw)
  To: dev, qi.z.zhang, beilei.xing; +Cc: Liulingyu

When create a rule with following invalid RSS type combinations,
it should fails.

Invalid RSS combinations list:
- ETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_TCP
- ETH_RSS_IPV6 | ETH_RSS_NONFRAG_IPV6_TCP

This patch adds these combinations in 'invalid_rss_comb' array to
do valid check, if the combination check failed, the rule will be
created failed.

Signed-off-by: Liulingyu <lingyu.liu@intel.com>
---
 drivers/net/ice/ice_hash.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
index 7d7e7052da..e56cdf9941 100644
--- a/drivers/net/ice/ice_hash.c
+++ b/drivers/net/ice/ice_hash.c
@@ -826,7 +826,9 @@ static void ice_refine_hash_cfg(struct ice_rss_hash_cfg *hash_cfg,
 
 static uint64_t invalid_rss_comb[] = {
 	ETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_UDP,
+	ETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_TCP,
 	ETH_RSS_IPV6 | ETH_RSS_NONFRAG_IPV6_UDP,
+	ETH_RSS_IPV6 | ETH_RSS_NONFRAG_IPV6_TCP,
 	RTE_ETH_RSS_L3_PRE40 |
 	RTE_ETH_RSS_L3_PRE56 |
 	RTE_ETH_RSS_L3_PRE96
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH v1] net/ice: add invalid RSS combinations
  2021-04-08 15:54 [dpdk-dev] [PATCH v1] net/ice: add invalid RSS combinations Liulingyu
@ 2021-04-13  5:15 ` Zhang, Qi Z
  0 siblings, 0 replies; 2+ messages in thread
From: Zhang, Qi Z @ 2021-04-13  5:15 UTC (permalink / raw)
  To: Liu, Lingyu, dev, Xing, Beilei



> -----Original Message-----
> From: Liu, Lingyu <lingyu.liu@intel.com>
> Sent: Thursday, April 8, 2021 11:55 PM
> To: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Cc: Liu, Lingyu <lingyu.liu@intel.com>
> Subject: [PATCH v1] net/ice: add invalid RSS combinations
> 
> When create a rule with following invalid RSS type combinations, it should
> fails.
> 
> Invalid RSS combinations list:
> - ETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_TCP
> - ETH_RSS_IPV6 | ETH_RSS_NONFRAG_IPV6_TCP
> 
> This patch adds these combinations in 'invalid_rss_comb' array to do valid
> check, if the combination check failed, the rule will be created failed.
> 
> Signed-off-by: Liulingyu <lingyu.liu@intel.com>

Renamed to "Lingyu Liu <lingyu.liu@intel.com>" to align with the required format.

Acked: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-13  5:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 15:54 [dpdk-dev] [PATCH v1] net/ice: add invalid RSS combinations Liulingyu
2021-04-13  5:15 ` Zhang, Qi Z

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git