From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F3AEA0C42; Fri, 9 Apr 2021 01:01:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED85F4068E; Fri, 9 Apr 2021 01:01:43 +0200 (CEST) Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by mails.dpdk.org (Postfix) with ESMTP id A22B14014D for ; Fri, 9 Apr 2021 01:01:42 +0200 (CEST) Received: by mail-pg1-f181.google.com with SMTP id p12so2439571pgj.10 for ; Thu, 08 Apr 2021 16:01:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mcwDNtDOQAU4ddq5MKySIalV97ImC+0KF0FJCLOElnw=; b=Ed+ogKbP+vjBRoC/FIYWWzAFWsFABU/k7mYGur/z1uxypQBkGXHk3f+o+dHNIerB4y nBM0GY7gAADL+ShBjY3cVGm48ZOm61TNxZs+gplBT/0EVrwFUMi1CX3StGnXAJaN3XGE edavPzgyamMeMGl2SCy6W8IL2tMR6YWZji8nRJ5PzHaxHbpgd0JabFgF9hvEZ6n7Iur9 Wz2KcYWUDGabp0ZSkPWUAYTa5JaF7pYDrCXCQNj0eQ0xtWFvJWb7M2Bq0m/8U+tkfuZ4 K8JASekUdaUd2sAowPWlOriEcKKiLLH5tZNCkFdgQbGOMcMMw2WrZTecwshb4+4ywBlP /aJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mcwDNtDOQAU4ddq5MKySIalV97ImC+0KF0FJCLOElnw=; b=qPL2oC2AarO1zgsLemP4HSacHrmQf9Vt+CI0sewcRSJGbI9Q7s5kxF8E5Tce/eIBE4 l7ghnDQ3bQjSn8qbTaJE/ankDpwLVZyon3/i2k0S6k/vAinTRfhMlXCpNwi7S1GzD744 BVbgJ0+xY4a+j3rVecMB2fe3VBQj1cMB1iDV+9bV04KX/DomCBbnI/pURg8ON+xT2t2J Ll3mQh68JuryZBjsSyrz4EJ8yg6TuR+fds2nOElyPyiZjrTyxIi8XgLAiHwFrFP8do5D VyQAxvJm7fY4ezi9Yr+1ZJSKDGHAZUZcmwJRdxhxfj9NJlEHAbbq+XfCkOb4JfAJEuSt naYA== X-Gm-Message-State: AOAM532W0bbN73SvtBZDfosX5nBt+5Ug4fn5we9HNIdco6FwUY/vAaIL imrElJouBKB7qLowGSxszzu4LQ== X-Google-Smtp-Source: ABdhPJzJ6VMMhO7J6PQa1rho+P/aldQ6rVynIVgq+XsHHYy3QGqSnW7XkTuUOAY/4FhouKaIbCqHzg== X-Received: by 2002:a63:f715:: with SMTP id x21mr10027515pgh.399.1617922901833; Thu, 08 Apr 2021 16:01:41 -0700 (PDT) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id e9sm345758pgk.69.2021.04.08.16.01.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Apr 2021 16:01:41 -0700 (PDT) Date: Thu, 8 Apr 2021 16:01:09 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: "Amber, Kumar" , "Wang, Yipeng1" , dev@dpdk.org, "Richardson, Bruce" , "Gobriel, Sameh" Message-ID: <20210408160109.1cc492e5@hermes.local> In-Reply-To: <23449419.HG3X9kRrra@thomas> References: <20210112072446.880122-1-kumar.amber@intel.com> <9326090.qLjmXhQq0I@thomas> <23449419.HG3X9kRrra@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1] lib/hash: support non sse42 cpu architecture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 09 Apr 2021 00:41:34 +0200 Thomas Monjalon wrote: > 25/03/2021 09:06, Thomas Monjalon: > > 24/03/2021 23:59, Wang, Yipeng1: > > > From: kumar amber > > > > > > > > add _SSE42_ flag to enable compilation of > > > > sse42 specific instructions only on supported architecture > > > > > > > > Signed-off-by: kumar amber > [...] > > > [Wang, Yipeng] > > > Hi, Kumar, thanks for the patch. > > > I think the minimum required machine for x86 is sse4.2 compatible already. So I wonder if we really need this. > > > > Yes, that's why I don't understand this patch. > > Any comment? Should we reject the patch? > > > The only use case would be running DPDK in a VM for a hypervisor that disables those instructions in guest. Some old crufty hypervisors don't handle it??