From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id AC0A8A0C3F;
	Thu,  8 Apr 2021 21:51:39 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 435E31411C2;
	Thu,  8 Apr 2021 21:51:39 +0200 (CEST)
Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com
 [209.85.167.47])
 by mails.dpdk.org (Postfix) with ESMTP id C1F94141149
 for <dev@dpdk.org>; Thu,  8 Apr 2021 21:51:37 +0200 (CEST)
Received: by mail-lf1-f47.google.com with SMTP id b4so5974482lfi.6
 for <dev@dpdk.org>; Thu, 08 Apr 2021 12:51:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=iyLVDJBNQAtaD47nRgHhW1Vll+DPx8ZyJR04rLYDcGE=;
 b=JYXuBns982iE19dNwO7svz3GXNptOC/dOfHP9xqPdYkcfO4iyr/HXF864hYOEMdSWM
 WMBfyfubs1T9AnBZYKQOsoczjQgoEeYzoVNZAS2HTbXQsFo+OnC/LwWbZjzDvCuUaRIw
 LivYiSvWHdukubCIaIctZodkPtrmFDDkVjEESLzHrls+qiqvUCE9Tl8jsGP1Ub0q6m3p
 TgrLonARPSozU/SL9MiN/9467k9IQGYqV49cvW54nFsJGYCLOogfTXEQIVEcOyArIHse
 WlyIbGmwtSwfAW0hwHdV4rZFtQDi6FkgUAgRa+RMCdBXUsaiInVUpjSJkTLZRZFblON+
 4w5Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=iyLVDJBNQAtaD47nRgHhW1Vll+DPx8ZyJR04rLYDcGE=;
 b=VwFo6DR5F3Tk4tIfCFUGCvj6P0UcFwfnlAs4qWfN+o7bAvEA6HT3exlEzRxOe5qYoF
 VOWAyQxpyw4eoRPv9Ws/kluuu6bS6MBUwRnsOvlmztKUhMtblw4K2/SH12AwHiCzP+JT
 LWAkt1VMSorK0blSYU30OpMLwQjm6pZrcgmPCBnBpe1HBqcK0Hm5JTocx8Yr1NMmB4XI
 vFJHLJvTvY4aW0CF8E+to6UIb3Jlig/7NXWksd1BQzX18oRe4HFHssVOc+PF07jJVYxZ
 amjZzirZHW4nTtqkko1sUH/SUBtV/zNKTX0TM2qqM0zq+flRdI6YRTD7Nw1zqyOnlZeD
 hMrg==
X-Gm-Message-State: AOAM531WT/AHLBJJCL5cZv449WLHcQsXBrDlAeGn9IdCRQ6Uv3fII9CE
 iVFSTukwPjJtwFJjG1rkGt4=
X-Google-Smtp-Source: ABdhPJzz37/PqEAnGB2XhuHfnzJR6WwH8rCCp16nsdWLhK3Bvyes1cTxDyfTLydMftP1Dc//LHLhYg==
X-Received: by 2002:a05:6512:c16:: with SMTP id
 z22mr8235144lfu.467.1617911497338; 
 Thu, 08 Apr 2021 12:51:37 -0700 (PDT)
Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru.
 [37.110.65.23])
 by smtp.gmail.com with ESMTPSA id o26sm26187ljc.138.2021.04.08.12.51.35
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 08 Apr 2021 12:51:36 -0700 (PDT)
Date: Thu, 8 Apr 2021 22:51:34 +0300
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, Tyler Retzlaff <roretzla@linux.microsoft.com>, Jie Zhou
 <jizh@linux.microsoft.com>, Nick Connolly <nick.connolly@mayadata.io>,
 Beilei Xing <beilei.xing@intel.com>, Jeff Guo <jia.guo@intel.com>, Matan
 Azrad <matan@nvidia.com>, Shahaf Shuler <shahafs@nvidia.com>, Viacheslav
 Ovsiienko <viacheslavo@nvidia.com>, Narcisa Ana Maria Vasile
 <navasile@linux.microsoft.com>, Dmitry Malloy <dmitrym@microsoft.com>,
 Pallavi Kadam <pallavi.kadam@intel.com>, Thomas Monjalon
 <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@intel.com>, Andrew
 Rybchenko <andrew.rybchenko@oktetlabs.ru>
Message-ID: <20210408225134.316758e8@sovereign>
In-Reply-To: <20210408114541.GV1650@platinum>
References: <20210403234129.20296-1-dmitry.kozliuk@gmail.com>
 <20210407222249.6729-1-dmitry.kozliuk@gmail.com>
 <20210407222249.6729-5-dmitry.kozliuk@gmail.com>
 <20210408114541.GV1650@platinum>
X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v8 4/4] net: provide IP-related API on any OS
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2021-04-08 13:45 (UTC+0200), Olivier Matz:
[...]
> > diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c
> > index c572d003cb..e7361bf520 100644
> > --- a/drivers/net/i40e/i40e_fdir.c
> > +++ b/drivers/net/i40e/i40e_fdir.c
> > @@ -22,6 +22,7 @@
> >  #include <rte_sctp.h>
> >  #include <rte_hash_crc.h>
> >  #include <rte_bitmap.h>
> > +#include <rte_os_shim.h>
> >    
> 
> If I understand the logic, rte_ip.h provides OS-specific IP-related
> stuff (like IPPROTO_*), and rte_os_shim.h provides the POSIX definitions
> that are missing after including rte_ip.h.
> 
> Would it make sense to include rte_os_shim.h from rte_ip.h, so that
> including rte_ip.h is always sufficient? Or is it because we want to
> avoid implicit inclusion of rte_os_shim.h?

Yes, currently rte_os_shim.h is not exposed at all.
It it ever will, this reason still applies.