DPDK patches and discussions
 help / color / mirror / Atom feed
From: Radha Mohan Chintakuntla <radhac@marvell.com>
To: <vburru@marvell.com>, <thomas@monjalon.net>
Cc: <dev@dpdk.org>, Radha Mohan Chintakuntla <radhac@marvell.com>
Subject: [dpdk-dev] [PATCH] raw/octeontx2_dma: fix unavailable PCI device in dpivf
Date: Fri, 9 Apr 2021 00:59:22 -0700	[thread overview]
Message-ID: <20210409075922.122787-1-radhac@marvell.com> (raw)

The PCI device address is being used for sending mailbox which was
introduced in previous commit which replaced the macros so that
multiple DPI blocks in the hardware can be supported.

This patch fixes a NULL pointer access by assigning the PCI device
structure to dpivf.

Fixes: 4495bd887d38 ("raw/octeontx2_dma: support multiple DPI blocks")

Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
 drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c b/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c
index efdba2779b..8c01f25ec7 100644
--- a/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c
+++ b/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c
@@ -389,6 +389,7 @@ otx2_dpi_rawdev_probe(struct rte_pci_driver *pci_drv __rte_unused,
 	vf_id = ((pci_dev->addr.devid & 0x1F) << 3) |
 		 (pci_dev->addr.function & 0x7);
 	vf_id -= 1;
+	dpivf->dev = pci_dev;
 	dpivf->state = DPI_QUEUE_START;
 	dpivf->vf_id = vf_id;
 	dpivf->vf_bar0 = (uintptr_t)pci_dev->mem_resource[0].addr;

             reply	other threads:[~2021-04-09  7:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-09  7:59 Radha Mohan Chintakuntla [this message]
2021-04-09  8:07 ` Radha Mohan
  -- strict thread matches above, loose matches on Subject: below --
2021-03-22 15:21 Radha Mohan Chintakuntla
2021-04-09  6:43 ` Jerin Jacob
2021-04-09  8:01   ` Radha Mohan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210409075922.122787-1-radhac@marvell.com \
    --to=radhac@marvell.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=vburru@marvell.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).