From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 808C2A0579; Fri, 9 Apr 2021 10:39:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 686E61413EF; Fri, 9 Apr 2021 10:39:41 +0200 (CEST) Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by mails.dpdk.org (Postfix) with ESMTP id 4111B1413EA for ; Fri, 9 Apr 2021 10:39:40 +0200 (CEST) Received: from localhost (unknown [10.16.0.62]) by proxy.6wind.com (Postfix) with ESMTP id 2A1DE91F295; Fri, 9 Apr 2021 10:39:40 +0200 (CEST) From: Gabriel Ganne To: Bruce Richardson Cc: dev@dpdk.org, thomas@monjalon.net, thierry.herbelot@6wind.com, olivier.matz@6wind.com, Gabriel Ganne Date: Fri, 9 Apr 2021 10:39:27 +0200 Message-Id: <20210409083927.8345-1-gabriel.ganne@6wind.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210322140757.7888-2-gabriel.ganne@6wind.com> References: <20210322140757.7888-2-gabriel.ganne@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v4] meson: remove unnecessary explicit link to libpcap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" libpcap is already found and registered as a dependency by meson, and the dependency is already correctly used in librte_port. This line is just unnecessary. The pcap PMD and the librte_port both declare their dependency to libpcap with a line "ext_deps += pcap_dep". "pcap_dep" is declared using the dependency() directive in config/meson.build meson automatically adds this dependency to the pkg-config file in the private section for static builds. Signed-off-by: Gabriel Ganne --- config/meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/config/meson.build b/config/meson.build index 66a2edcc47f5..95777cf33169 100644 --- a/config/meson.build +++ b/config/meson.build @@ -183,7 +183,6 @@ if not pcap_dep.found() endif if pcap_dep.found() and cc.has_header('pcap.h', dependencies: pcap_dep) dpdk_conf.set('RTE_PORT_PCAP', 1) - dpdk_extra_ldflags += '-lpcap' endif # for clang 32-bit compiles we need libatomic for 64-bit atomic ops -- 2.29.2