From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B36AAA0579; Fri, 9 Apr 2021 14:26:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B3BB140F50; Fri, 9 Apr 2021 14:26:05 +0200 (CEST) Received: from wnew1-smtp.messagingengine.com (wnew1-smtp.messagingengine.com [64.147.123.26]) by mails.dpdk.org (Postfix) with ESMTP id 781394014D; Fri, 9 Apr 2021 14:26:04 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.west.internal (Postfix) with ESMTP id 7BFD613D5; Fri, 9 Apr 2021 08:26:02 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 09 Apr 2021 08:26:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm3; bh=e4s/tQlFfpfl8 4sabmzCEIeWQfgvpJjGPchn8j6v0EY=; b=T2wY3byGInP06+JMlYTGshIHPF/l0 rLrgT8ct7opIOSb7Y2dIzaTU992tZJD2GZXvoFPF5xIUWOdek+Mdo5JvKTkXTkwN VRaoTCb20YAztpEazQQ3xLomzyH9fgv9X4oVA5acrtV4eYQP1cHF1mOzE5pTl4Un ILlgROOfXkXKml0LeTdZWSW3yjq8jvlPTxoQ0IrDjDA1feGyZvZLPC/DlVboFNVQ WW7Osabd9B024v4Fe7ffaxIpk4LBwnu7xyInIYyDvCcEtwqS1wJDGUSr6A0zto1d zjh3MCyekIOmCcnASz+urRxLh0aIcg861WwY3osmOsTxH8VxR8GVV2WmQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=e4s/tQlFfpfl84sabmzCEIeWQfgvpJjGPchn8j6v0EY=; b=Qw1UEj9X iKsK2qcS36j+L8X7Xsv5dyrwrn99Moxv+UAQjr0uDkiES2ti0/Ak1bWi7111+pDR uyYxr3lklnrA5qYdX7NaDQOQZufBjs2kOccFj/Z7i388m62KQq1Kr4FX3g7pWdzh PMaoj5+fgfh1ooQrimCgFmR5S+M/JRh7MojY2uex59MBeetnlZu4zKtf+lhf4uj5 ZTFQNku02UPwpFShj6pGqmQ93EfyNZqR03OA7cPQw+j2Cydf1EUHuDBFGavHZE8P XmQyuM0ucM5OdiiACbBuOjhNl7YTQ0lOyIVSO2N2xrq4BCzaQCwq3lofvSwxgn4E 8Ufo0e20ofctvg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekuddgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6F5251080054; Fri, 9 Apr 2021 08:26:00 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: bruce.richardson@intel.com, bluca@debian.org, dmitry.kozliuk@gmail.com, olivier.matz@6wind.com, thierry.herbelot@6wind.com, Gabriel Ganne , stable@dpdk.org, Harry van Haaren , Luca Boccassi , Keith Wiles Date: Fri, 9 Apr 2021 14:25:51 +0200 Message-Id: <20210409122551.265939-1-thomas@monjalon.net> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210409083927.8345-1-gabriel.ganne@6wind.com> References: <20210409083927.8345-1-gabriel.ganne@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v5] build: remove redundant libpcap link X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Gabriel Ganne The pcap PMD and the librte_port both declare their dependency to libpcap with a line "ext_deps += pcap_dep". Then meson automatically adds this dependency to the pkg-config file in the "Requires.private" section for static builds. The additional update of dpdk_extra_ldflags was adding the dependency in the "Libs.private" section of the pkg-config, that is unnecessary. Fixes: efd5d1a8d8dd ("drivers/net: build some vdev PMDs with meson") Fixes: 268fa581b1ff ("port: fix pcap support with meson") Cc: stable@dpdk.org Signed-off-by: Gabriel Ganne Signed-off-by: Thomas Monjalon --- I have a doubt whether this option is really always useless. In the case of an old pcap (<1.9) without pkg-config support, and with the minimum meson supported (0.47.1), are we sure the generated pkg-config file will include -lpcap? --- config/meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/config/meson.build b/config/meson.build index 66a2edcc47..95777cf331 100644 --- a/config/meson.build +++ b/config/meson.build @@ -183,7 +183,6 @@ if not pcap_dep.found() endif if pcap_dep.found() and cc.has_header('pcap.h', dependencies: pcap_dep) dpdk_conf.set('RTE_PORT_PCAP', 1) - dpdk_extra_ldflags += '-lpcap' endif # for clang 32-bit compiles we need libatomic for 64-bit atomic ops -- 2.31.1